Re: Preserving cache name and storage level upon table refresh

2019-05-03 Thread William Wong
Hi @gatorsmile, @cloud-fan and Sean, Thanks for previous review and suggestions. I updated the test case to cover storage level, fixed the typo on the migration note and applied some other enhancements. Sorry that I accidentally reformat the QueryTest.scala and introduced many unnecessary changes

Re: Preserving cache name and storage level upon table refresh

2019-04-15 Thread William Wong
Hi Sean and @gatorsmile , Thanks a lot for your previous review. I updated those test ( https://github.com/apache/spark/pull/24221) accordingly. May I know if you can help reviewing them again? Best regards, William On Wed, Apr 3, 2019 at 1:03 AM William Wong wr

Preserving cache name and storage level upon table refresh

2019-04-02 Thread William Wong
Dear Spark developers, We noticed that cache name could be changed upon table refreshing. It is because CatalogImpl.refreshTable would first uncached and then recache (lazily) without first preserving cache name (and its storage level). IMHO, it is not what a user would expect. I submitted a JIRA