Re: Add spark dependency on on org.opencypher:okapi-shade.okapi

2019-10-18 Thread Weichen Xu
Attach the design doc here https://docs.google.com/document/d/1Wxzghj0PvpOVu7XD1iA8uonRYhexwn18utdcTxtkxlI/edit# I think the initial design intention is to replace graphx in spark. At first, we plan to merge graphframe project into spark, now this design is improved to not only include graphframe,

Re: Add spark dependency on on org.opencypher:okapi-shade.okapi

2019-10-16 Thread Reynold Xin
Just curious - did we discuss why this shouldn't be another Apache sister project? On Wed, Oct 16, 2019 at 10:21 AM, Sean Owen < sro...@gmail.com > wrote: > > > > We don't all have to agree on whether to add this -- there are like 10 > people with an opinion -- and I certainly would not veto

Re: Add spark dependency on on org.opencypher:okapi-shade.okapi

2019-10-16 Thread Sean Owen
We don't all have to agree on whether to add this -- there are like 10 people with an opinion -- and I certainly would not veto it. In practice a medium-sized changes needs someone to review/merge it all the way through, and nobody strongly objecting. I too don't know what to make of the situation;

Re: Add spark dependency on on org.opencypher:okapi-shade.okapi

2019-10-16 Thread Martin Junghanns
I'm slightly confused about this discussion. I worked on all of the aforementioned PRs: the module PR that has been merged, the current PR that introduces the Graph API and the PoC PR that contains the full implementation. The issues around shading were addressed and the module PR eventually got me

Re: Add spark dependency on on org.opencypher:okapi-shade.okapi

2019-10-15 Thread Sean Owen
I do not have a very informed opinion here, so take this with a grain of salt. I'd say that we need to either commit a coherent version of this for Spark 3, or not at all. If it doesn't have support, I'd back out the existing changes. I was initially skeptical about how much this needs to be in Sp

Re: Add spark dependency on on org.opencypher:okapi-shade.okapi

2019-10-15 Thread Weichen Xu
Hi Mats Rydberg, Although this dependency "org.opencypher:okapi-shade.okapi" was added into spark, but Xiangrui raised two concerns (see above mail) about it, so we'd better rethink on this and consider whether this is a good choice, so I call this vote. Thanks! On Tue, Oct 15, 2019 at 10:56 PM

Re: Add spark dependency on on org.opencypher:okapi-shade.okapi

2019-10-15 Thread Mats Rydberg
Hello Weichen, community I'm sorry, I'm feeling a little bit confused about this vote. Is this about the PR (https://github.com/apache/spark/pull/24490) that was merged in early June and introduced the spark-graph module including the okapi-shade dependency? Regarding the okapi-shade dependency w

Add spark dependency on on org.opencypher:okapi-shade.okapi

2019-10-15 Thread Weichen Xu
Hi everyone, I'd like to call a new vote on the issue: should we add dependency "org.opencypher:okapi-shade.okapi" into spark ? The issue background is: Spark is going to add a big feature "Spark Graph", the prototypical implementation is here https://github.com/apache/spark/pull/24297 which will