Re: [REMINDER] 4.0 branch cut is coming

"branch-4.0" has been cut. Please merge commits to this branch as well if you think it's necessary before Feb 1. On Wed, Jan 15, 2025 at 4:37 PM Wenchen Fan wrote: > Yes, I'll start a new thread this week to collect the ongoing projects and > track the progress. We can discuss there and see if t

Re: [REMINDER] 4.0 branch cut is coming

Yes, I'll start a new thread this week to collect the ongoing projects and track the progress. We can discuss there and see if the code freeze date (Feb 1) is reasonable or not. But in any case, we should try our best to stick with the schedule, or we need to vote to change the date. On Wed, Jan 1

Re: [REMINDER] 4.0 branch cut is coming

Shall we not focus on the date itself but focus on the delivery? I don't have any concern about branch cut, but the starting date of the QA period sounds really tight. We have two weeks remaining, and one week will be a national holiday of both China and South Korea. Shall we collect and check the

Re: [REMINDER] 4.0 branch cut is coming

Yep, if you insist. Thanks, Dongjoon. On Wed, Jan 15, 2025 at 12:10 AM Wenchen Fan wrote: > Dongjoon, let's take it easy. I'll cut the branch today to stick with the > committed schedule (2025-01-15), and I'll pick a time that is > convenient for me (likely 9 PM UTC+8). As I mentioned earlier,

Re: [REMINDER] 4.0 branch cut is coming

Dongjoon, let's take it easy. I'll cut the branch today to stick with the committed schedule (2025-01-15), and I'll pick a time that is convenient for me (likely 9 PM UTC+8). As I mentioned earlier, people can keep backporting commits to the 4.0 branch before February 1, so we don't have any blocke

Re: [REMINDER] 4.0 branch cut is coming

Let me enumerate some questions. 1. Since you have no open list, do you have some internal PRs which are planned to be open the rest of Today? 2. For the timezone, the following timezone was originally proposed by Hyukjin and agreed by me. Apparently, you disagree with this because you don

Re: [REMINDER] 4.0 branch cut is coming

I don't have any specific PRs in mind, as I review PRs almost daily: PRs I've commented on . Since it's still within my working hours today, I’d prefer to do the branch cut after I finish my day. I hope this is a r

Re: [REMINDER] 4.0 branch cut is coming

Well, previously, you didn't have specific PRs in your very previous email. > I don't have specific PRs in mind, Now, it seems that you made up your mind to tell what is going on there. Which PRs are those? > I'm still reviewing and may merge PRs during the daytime. Let's see what your real con

Re: [REMINDER] 4.0 branch cut is coming

OK nice joke, I should have said 2025-01-15 23:59:59 PST :) Anyway, I'll cut the branch tonight in my timezone (UTC+8) as I'm still reviewing and may merge PRs during the daytime. The branch cut will still be on 2025-01-15 and please let me know if the policy requires the time to be midnight PST.

Re: [REMINDER] 4.0 branch cut is coming

We provide sufficient information in advance on our website and mailing list. Exactly one week ago, we also had the dev mailing threads about `Spark 4.0.0 timeline`. https://lists.apache.org/thread/vq00tmwz6x4ddjypk2rmw8ktotty0pb6 (2025-01-07) In addition, Apache Spark also complains about the p

Re: [REMINDER] 4.0 branch cut is coming

I don't have specific PRs in mind, I'm just referring to the huge amount of commits we merge every day: https://github.com/apache/spark/commits/master BTW, 4 hours seems too short for a reminder, why not 2025-01-15 24:00:00 PST? I can do it as it will be my afternoon at my timezone. On Wed, Jan 1

Re: [REMINDER] 4.0 branch cut is coming

I don't have any examples :-). Just wanted to make sure. +1 for cutting soon as scheduled. On Wed, 15 Jan 2025 at 12:55, Dongjoon Hyun wrote: > Thank you, Wenchen and Hyukjin. > > BTW, if you can, please provide specific PRs which you are referring to as > active. > > I can help those PRs as muc

Re: [REMINDER] 4.0 branch cut is coming

Thank you, Wenchen and Hyukjin. BTW, if you can, please provide specific PRs which you are referring to as active. I can help those PRs as much as possible if I can. For `branch-4.0`, as Hyukjin mentioned, I'm going to create it at midnight PST (Today, 2025-01-15 00:00:00 PST). In other words,

Re: [REMINDER] 4.0 branch cut is coming

one alternative would be to cut the branch at midnight in PST as relatively more commits are coming in daytime in PST. On Wed, 15 Jan 2025 at 12:12, Hyukjin Kwon wrote: > Yeah, I agree that cutting in the middle of week, e.g., commits are being > merged, it might cause some confusions which bran

Re: [REMINDER] 4.0 branch cut is coming

Yeah, I agree that cutting in the middle of week, e.g., commits are being merged, it might cause some confusions which branch committers should target for a while. If we're all happy with that, I am fine going ahead as scheduled. On Wed, 15 Jan 2025 at 12:03, Wenchen Fan wrote: > I don’t have a

Re: [REMINDER] 4.0 branch cut is coming

I don’t have a strong preference, as people can backport whatever they need to the 4.0 branch before February 1. My intention was to avoid interrupting others’ work in the middle of a week when PRs are actively being merged, and I thought the weekend would be a better time. However, I’m fine with e

Re: [REMINDER] 4.0 branch cut is coming

Hi, Wenchen. I'd not delay the branch cut. We had better stick to our plan and those week days to stablize branch-4.0. If you are busy, I'm going to cut the branch on schedule (2015-01-15) and help the on-going PR reviews. As you mentioned, we don't block feature backportings. There is no reason

[REMINDER] 4.0 branch cut is coming

Hi all, According to the schedule , the 4.0 branch cut is set for January 15. I plan to cut the branch at the end of this week so that folks can have a few more working days to complete the ongoing work. Note: While we can still merge PRs to the 4.