Re: [MLlib] BinaryLogisticRegressionSummary on test set

If you have the time, submitting a PR for it would be awesome! However, our review bandwidth is limited so you should not expect it to get immediately reviewed. Let's continue discussion of the name on JIRA On Fri, Sep 18, 2015 at 2:47 AM, Hao Ren wrote: > Thank you for the reply. > > I have cre

Re: [MLlib] BinaryLogisticRegressionSummary on test set

Thank you for the reply. I have created a jira issue and pinged mengxr. Here is the link: https://issues.apache.org/jira/browse/SPARK-10691 I did not find jkbradley on jira. I saw he is on github. BTW, should I create a pull request on removing the private modifier for further discussion ? Thx

Re: [MLlib] BinaryLogisticRegressionSummary on test set

We have kept that private because we need to decide on a name for the method which evaluates on a test set (see the TODO comment ); perhaps you could push for this to happen by creating a Jira and pinging jkb

[MLlib] BinaryLogisticRegressionSummary on test set

Working on spark.ml.classification.LogisticRegression.scala (spark 1.5), It might be useful if we can create a summary for any given dataset, not just training set. Actually, BinaryLogisticRegressionTrainingSummary is only created when model is computed based on training set. As usual, we need to