Re: [K8S] KUBERNETES_EXECUTOR_REQUEST_CORES

2021-02-10 Thread attilapiros
Hi, This is just an extra unnecessary usage of the /sparkConf/ member val directly (those two lines are added by two different PRs). Actually both uses the same /sparkConf/ to give back the config value, as /KubernetesExecutorConf/ extends the /KubernetesConf/ [1] which uses the passed /sparkConf

[K8S] KUBERNETES_EXECUTOR_REQUEST_CORES

2021-01-12 Thread Jacek Laskowski
Hi, I'm curious why this line [1] uses sparkConf to find KUBERNETES_EXECUTOR_REQUEST_CORES while the next [2] goes to kubernetesConf? (I'm not going to mention it's getOrElse case here and wait till I got OK to change this due to the above "misuse"). [1] https://github.com/apache/spark/blob/mast