[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/95#issuecomment-36965043 If there's consensus on a different identifier, I'd be happy to post an addendum patch. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread mridulm
Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/95#issuecomment-36964810 I would have preferred a different identifier (though I dont have good alternatives yet), but that seems moot now since the PR was closed before I could get to it.

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/95 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/95#issuecomment-36958050 @sryza thanks I'll merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/95#issuecomment-36956664 Updated patch incorporates review feedback --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/95#issuecomment-36939035 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13026/ --- If your project i

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/95#issuecomment-36939034 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/95#issuecomment-36938497 Looks good to me (with the doc fixes commented on). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread yaoshengzhe
Github user yaoshengzhe commented on the pull request: https://github.com/apache/spark/pull/95#issuecomment-36938296 @pwendell I agree what you saying. One more question, is that possible to move all these string constants in some class ? --- If your project is set up for it, you

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/95#discussion_r10361302 --- Diff: docs/running-on-yarn.md --- @@ -82,35 +84,30 @@ For example: ./bin/spark-class org.apache.spark.deploy.yarn.Client \ --ja

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/95#discussion_r10360720 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1243,7 +1245,7 @@ object SparkContext { } scheduler

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/95#issuecomment-36936989 @sryza thanks Sandy this looks good to me. @tgraves want to take a look? If not I can merge this tonight - it's just some doc fixes. --- If your project is set up for it,

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/95#issuecomment-36936894 @yaoshengzhe this supports "yarn-standalone" for backwards compatibility so you don't need to change your application. The name "yarn-standalone" is really confusing becau

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/95#discussion_r10360526 --- Diff: docs/running-on-yarn.md --- @@ -82,35 +84,30 @@ For example: ./bin/spark-class org.apache.spark.deploy.yarn.Client \ --jar

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread yaoshengzhe
Github user yaoshengzhe commented on the pull request: https://github.com/apache/spark/pull/95#issuecomment-36935885 Hi Sandy, What is the point to give a new name to "yarn-standalone" ? I think it requires people to change their spark code build for yarn and create some confusion