[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-07 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/94#issuecomment-37053538 thanks tom, merged this into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-07 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/94#issuecomment-37053143 LGTM thanks for improving the existing code here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/94#issuecomment-37040302 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/94#issuecomment-37040303 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13047/ --- If your project i

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/94#issuecomment-37034714 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/94#issuecomment-37034713 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-07 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/94#discussion_r10384191 --- Diff: core/src/test/scala/org/apache/spark/PipedRDDSuite.scala --- @@ -89,4 +97,37 @@ class PipedRDDSuite extends FunSuite with SharedSparkContext {

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-06 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/94#discussion_r10374683 --- Diff: core/src/test/scala/org/apache/spark/PipedRDDSuite.scala --- @@ -89,4 +97,37 @@ class PipedRDDSuite extends FunSuite with SharedSparkContext {

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-06 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/94#discussion_r10368475 --- Diff: core/src/test/scala/org/apache/spark/PipedRDDSuite.scala --- @@ -89,4 +97,37 @@ class PipedRDDSuite extends FunSuite with SharedSparkContext {

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-06 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/94#issuecomment-36948463 Adding a routine to HadoopPartition sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-06 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/94#discussion_r10365444 --- Diff: core/src/test/scala/org/apache/spark/PipedRDDSuite.scala --- @@ -89,4 +97,37 @@ class PipedRDDSuite extends FunSuite with SharedSparkContext {

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-06 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/94#discussion_r10364545 --- Diff: core/src/test/scala/org/apache/spark/PipedRDDSuite.scala --- @@ -89,4 +97,37 @@ class PipedRDDSuite extends FunSuite with SharedSparkContext {

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-06 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/94#discussion_r10364522 --- Diff: core/src/test/scala/org/apache/spark/PipedRDDSuite.scala --- @@ -89,4 +97,37 @@ class PipedRDDSuite extends FunSuite with SharedSparkContext {

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-06 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/94#issuecomment-36946598 hey @tgravescs good catch on this one. In terms of abstracting. The most abstract we could do would be to add a method to a `Partition` called `getPipeEnvVars` or

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-06 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/94#discussion_r10364651 --- Diff: core/src/main/scala/org/apache/spark/rdd/PipedRDD.scala --- @@ -59,6 +61,20 @@ class PipedRDD[T: ClassTag]( val currentEnvVars = pb.environme

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/94#issuecomment-36939044 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/94#issuecomment-36939045 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13024/ --- If your project i

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/94#issuecomment-36932975 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/94#issuecomment-36932976 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: SPARK-1195: set map_input_file environment var...

2014-03-06 Thread tgravescs
GitHub user tgravescs opened a pull request: https://github.com/apache/spark/pull/94 SPARK-1195: set map_input_file environment variable in PipedRDD Hadoop uses the config mapreduce.map.input.file to indicate the input filename to the map when the input split is of type FileSplit. S