Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36955323
I committed this, thanks for all the reviews Patrick!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36955086
Nope nothing else to address in this. I'll merge it shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36943591
Hey @tgravescs this looks good to me. Is there anything else you'd like to
address before merging this? If not, feel free to merge it into master.
---
If your project is
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/33#discussion_r10361820
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -135,6 +135,8 @@ class SparkContext(
val isLocal = (master == "local" ||
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/33#discussion_r10361204
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -135,6 +135,8 @@ class SparkContext(
val isLocal = (master == "local" || m
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36831096
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13021/
---
If your project i
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36831095
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36828590
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36828586
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36828591
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13020/
---
If your project i
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36826678
@pwendell Ok this should now be ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36826673
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36826306
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36826305
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36825493
Pass securityManager and SparkConf around where we can. Note the changes
to JettyUtils and calling functions. Switch to use SparkConf for getting and
setting configs whe
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36824999
@tgravescs let me know when you've stopped changing things around. I can do
a final pass. If there are just small things we can punt them to a subsequent
PR to avoid merge
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36821650
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36821651
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13013/
---
If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36821539
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36821538
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36781865
filed https://spark-project.atlassian.net/browse/SPARK-1191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36778996
@tgravescs Sure thing - but could you make the JIRA a blocker for Spark
1.0? It would be great if you could enumerate what assumptions are broken in
the current model (the
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36764964
yes I haven't made that change yet. I should have a patch up in a few hours
with that changed. I'm just doing some finally testing on it. I'm changing it
to pass the sec
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36762448
Ah I see from your earlier comment that's still a "TODO" perhaps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/33#issuecomment-36762162
Hey @tgravescs I noticed the `SecurityManager` still reads the system
properties directly. Any reason this can't be changed to take a `SparkConf` on
instantiation? The way
26 matches
Mail list logo
