[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-15 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/125#discussion_r10636342 --- Diff: dev/rat.bash --- @@ -0,0 +1,49 @@ +#!/usr/bin/env bash --- End diff -- could you remove the `.bash` extension here? --- If your pr

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37736072 @ScrapCodes this is a good start but right now it doesn't actually fail the build if RAT doesn't succeed. Also, RAT reports a bunch of failures for python files that I th

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37540004 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13160/ --- If your project

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37540002 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37533178 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37533207 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37533179 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13159/ --- If your project

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37533206 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-13 Thread ScrapCodes
Github user ScrapCodes commented on a diff in the pull request: https://github.com/apache/spark/pull/125#discussion_r10562618 --- Diff: project/plugins.sbt --- @@ -10,6 +10,8 @@ addSbtPlugin("com.typesafe.sbteclipse" % "sbteclipse-plugin" % "2.2.0") addSbtPlugin("com.git

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37527760 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37527761 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37523238 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37523239 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13158/ --- If your project

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37518962 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37518963 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-12 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37441481 Right now we manually run RAT before making releases - but the proposal here was to run it every time a PR is created. That will be much better since we will catch licens

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-12 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37435981 Hi @ScrapCodes, As @aarondav mentioned hopefully we do not need to have the RAT docs and jars in Spark source. I miss the part on why we do not want this

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-11 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37379933 @pwendell thoughts ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-11 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37379720 We did not want to have this in our builds (maven or SBT) and running this so trivial that it might not even need that. I am not sure about the dynamics of a release, b

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-11 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37327013 Aha right. Sorry don't have the code in front of me. Yeah the tension here is between making this available both places and duplicating the setup. Does the Maven plugin use

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-11 Thread markhamstra
Github user markhamstra commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37325883 @srowen Do you mean something other than ``` org.apache apache 13 ``` ...which is part of the maven build and already pulls

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-11 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37324720 Agree, this is normally deployed as a Maven plugin rather than a manually run Java program. I can provide that config if interested. Of course we have this wrinkle with als

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-11 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37319171 Do we have to include the actual rat docs and jar in our source, instead of being able to pull it down dynamically? The jar itself lends an extra 1.5MB to our source tree

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37295277 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37295279 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13115/ --- If your project

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37290407 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/125#issuecomment-37290408 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

2014-03-11 Thread ScrapCodes
GitHub user ScrapCodes opened a pull request: https://github.com/apache/spark/pull/125 SPARK-1144 Added license and RAT to check licenses. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ScrapCodes/spark-1 rat-integration Altern