Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10595816
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37611363
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37611365
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13174/
---
If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37611181
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37611180
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37601581
Yeah, workin on it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37601103
@sryza does this need to be bumped now with the workers/executors change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37507037
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37507039
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13155/
---
If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37506962
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37506964
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10554729
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37502813
@mateiz maybe you could take a pass on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10553709
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-3738
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37382223
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13127/
---
If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37382161
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37382160
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37381283
Updated patch takes review comments form @mridulm and @pwendell into
account.
spark.max.cores is now correctly handled. Jars passed in with --more-jars
are not add
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10506918
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10506816
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37265429
https://github.com/apache/spark/pull/119
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37088962
Newest patch includes tests and doc. @pwendell, do you have a link to the
addJar patch? If it's definitely going to happen, I'll take out the
classloader stuff here.
---
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37088937
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13063/
---
If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37088936
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37088913
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-37088912
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10406142
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10405655
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10399046
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10397696
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10397547
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10397541
--- Diff: bin/spark-submit ---
@@ -0,0 +1,38 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10374842
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10374821
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10374754
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10373471
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10373335
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10373228
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36967269
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13036/
---
If your pr
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10373180
--- Diff: bin/spark-submit ---
@@ -0,0 +1,38 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36967267
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36967210
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36967209
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36966736
I uploaded a new patch that doesn't start a new JVM and parses
--driver-memory in bash. It wasn't as bad as I expected (thanks to some help
from @umbrant and @atm).
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10372142
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36945861
I see, regarding the memory part, it sounds like we could do it in bash,
but it might be kind of painful. We could do the following:
- Look for just the driver memory and
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36939470
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13027/
---
If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36939469
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36939354
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36939213
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36937078
I uploaded a new patch that takes most of the review feedback into account.
Includes the following changes:
* changes Opt to OptionAssigner and uses default parameters
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10360322
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkAppArguments.scala ---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10359569
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10359483
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36828689
Thanks for taking a look, Matei. If we use system properties instead of
env variables, the remaining reason we'd want to start a second JVM is to be
able to have a --driver-
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36828535
Also, not sure what people think about calling this "spark-submit" instead
of "spark-app". For the in-cluster use case it's really just for submitting,
and I imagine that ca
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36828505
Hey Sandy, the overall approach looks good, though I made some comments
throughout. It would be really nice to avoid launching a second JVM if
possible. It seems that the ma
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10332780
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkAppArguments.scala ---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (A
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10332786
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10332762
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10332726
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10332714
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10332708
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkAppArguments.scala ---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10332688
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkAppArguments.scala ---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10332670
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10332654
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10332644
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10332582
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10332560
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10331680
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10331562
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkAppArguments.scala ---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10331365
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkAppArguments.scala ---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10331320
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10331185
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10331089
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10331035
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkAppArguments.scala ---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10330871
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10330832
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10330672
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkAppArguments.scala ---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/86#discussion_r10330438
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkAppArguments.scala ---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36812637
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36812638
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13010/
---
If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36812535
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/86#issuecomment-36812536
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
GitHub user sryza opened a pull request:
https://github.com/apache/spark/pull/86
SPARK-1126. spark-app preliminary
This is a starting version of the spark-app script for running compiled
binaries against Spark. It still needs tests and some polish. The only
testing I've done so
86 matches
Mail list logo
