Re: [DISCUSS] Syntax for table DDL

2018-10-04 Thread Ryan Blue
platform >>> to support both, by making the ANTLR extensible? >>> >>> >>> >>> -- >>> *From:* Alessandro Solimando >>> *Sent:* Tuesday, October 2, 2018 12:35 AM >>> *To:* rb...@netflix.com >>> *

Re: [DISCUSS] Syntax for table DDL

2018-10-03 Thread Wenchen Fan
ve >> compatible to ANSI SQL, say? >> >> Perhaps a more critical question, what does it take to get the platform >> to support both, by making the ANTLR extensible? >> >> >> >> -- >> *From:* Alessandro Solimando >

Re: [DISCUSS] Syntax for table DDL

2018-10-02 Thread Ryan Blue
upport both, by making the ANTLR extensible? > > > > -- > *From:* Alessandro Solimando > *Sent:* Tuesday, October 2, 2018 12:35 AM > *To:* rb...@netflix.com > *Cc:* Xiao Li; dev > *Subject:* Re: [DISCUSS] Syntax for table DDL > > I agre

Re: [DISCUSS] Syntax for table DDL

2018-10-02 Thread Felix Cheung
critical question, what does it take to get the platform to support both, by making the ANTLR extensible? From: Alessandro Solimando Sent: Tuesday, October 2, 2018 12:35 AM To: rb...@netflix.com Cc: Xiao Li; dev Subject: Re: [DISCUSS] Syntax for table DDL I

Re: [DISCUSS] Syntax for table DDL

2018-10-02 Thread Alessandro Solimando
I agree with Ryan, a "standard" and more widely adopted syntax is usually a good idea, with possibly some slight improvements like "bulk deletion" of columns (especially because both the syntax and the semantics are clear), rather than stay with Hive syntax at any cost. I am personally following t

Re: [DISCUSS] Syntax for table DDL

2018-10-01 Thread Ryan Blue
What do you mean by consistent with the syntax in SqlBase.g4? These aren’t currently defined, so we need to decide what syntax to support. There are more details below, but the syntax I’m proposing is more standard across databases than Hive, which uses confusing and non-standard syntax. I doubt t

Re: [DISCUSS] Syntax for table DDL

2018-09-28 Thread Xiao Li
Are they consistent with the current syntax defined in SqlBase.g4? I think we are following the Hive DDL syntax: https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-AlterTable/Partition/Column Ryan Blue 于2018年9月28日周五 下午3:47写道： > Hi everyone, > > I’m currently wo

[DISCUSS] Syntax for table DDL

2018-09-28 Thread Ryan Blue
Hi everyone, I’m currently working on new table DDL statements for v2 tables. For context, the new logical plans for DataSourceV2 require a catalog interface so that Spark can create tables for operations like CTAS. The proposed TableCatalog API also includes an API for altering those tables so we