Re: [DISCUSS] New sections in Github Pull Request description template

2019-07-30 Thread Hyukjin Kwon
I opened a PR https://github.com/apache/spark/pull/25310. Please take a look 2019년 7월 29일 (월) 오후 4:35, Hyukjin Kwon 님이 작성: > Thanks, guys. Let me probably mimic the template and open a PR soon - > currently I am stuck in some works. I will take a look in few days later. > > 2019년 7월 27일 (토) 오전 3:

Re: [DISCUSS] New sections in Github Pull Request description template

2019-07-29 Thread Hyukjin Kwon
Thanks, guys. Let me probably mimic the template and open a PR soon - currently I am stuck in some works. I will take a look in few days later. 2019년 7월 27일 (토) 오전 3:32, Bryan Cutler 님이 작성: > The k8s template is pretty good. Under the behavior change section, it > would be good to add instruction

Re: [DISCUSS] New sections in Github Pull Request description template

2019-07-26 Thread Bryan Cutler
The k8s template is pretty good. Under the behavior change section, it would be good to add instructions to also describe previous and new behavior as Hyukjin proposed. On Tue, Jul 23, 2019 at 10:07 PM Reynold Xin wrote: > I like the spirit, but not sure about the exact proposal. Take a look at

Re: [DISCUSS] New sections in Github Pull Request description template

2019-07-23 Thread Reynold Xin
I like the spirit, but not sure about the exact proposal. Take a look at k8s': https://raw.githubusercontent.com/kubernetes/kubernetes/master/.github/PULL_REQUEST_TEMPLATE.md On Tue, Jul 23, 2019 at 8:27 PM, Hyukjin Kwon wrote: > (Plus, it helps to track history too. Spark's commit logs are gr

Re: [DISCUSS] New sections in Github Pull Request description template

2019-07-23 Thread Hyukjin Kwon
(Plus, it helps to track history too. Spark's commit logs are growing and now it's pretty difficult to track the history and see what change introduced a specific behaviour) 2019년 7월 24일 (수) 오후 12:20, Hyukjin Kwon 님이 작성: > Hi all, > > I would like to discuss about some new sections under "## What

[DISCUSS] New sections in Github Pull Request description template

2019-07-23 Thread Hyukjin Kwon
Hi all, I would like to discuss about some new sections under "## What changes were proposed in this pull request?": ### Do the changes affect _any_ user/dev-facing input or output? (Please answer yes or no. If yes, answer the questions below) ### What was the previous behavior? (Please provid