Re: [DISCUSS] Handling correctness/data loss jiras

2019-01-05 Thread Xiao Li
+1 Reynold Xin 于2019年1月4日周五 上午9:28写道: > Committers, > > When you merge tickets fixing correctness bugs, please make sure you tag > the tickets with "correctness" label. I've found multiple tickets today that > didn't do that. > > > On Fri, Aug 17, 2018 at 7:11 AM, Tom Graves > wrote: > >> Since

Re: [DISCUSS] Handling correctness/data loss jiras

2019-01-04 Thread Reynold Xin
Committers, When you merge tickets fixing correctness bugs, please make sure you tag the tickets with "correctness" label. I've found multiple tickets today that didn't do that. On Fri, Aug 17, 2018 at 7:11 AM, Tom Graves < tgraves...@yahoo.com.invalid > wrote: > > Since we haven't heard any

Re: [DISCUSS] Handling correctness/data loss jiras

2018-08-17 Thread Tom Graves
Since we haven't heard any objections to this, the documentation has been updated (Thanks to Sean). All devs please make sure to re-read: http://spark.apache.org/contributing.html  . Note the set of labels used in Jira has been documented and correctness or data loss issues should be marked as b

Re: [DISCUSS] Handling correctness/data loss jiras

2018-08-14 Thread Imran Rashid
+1 on what we should do. On Mon, Aug 13, 2018 at 3:06 PM, Tom Graves wrote: > > > I mean, what are concrete steps beyond saying this is a problem? That's > the important thing to discuss. > > Sorry I'm a bit confused by your statement but also think I agree. I > started this thread for this rea

Re: [DISCUSS] Handling correctness/data loss jiras

2018-08-13 Thread Tom Graves
> I mean, what are concrete steps beyond saying this is a problem? That's the >important thing to discuss. Sorry I'm a bit confused by your statement but also think I agree.  I started this thread for this reason. I pointed out that I thought it was a problem and also brought up things I thoug

Re: [DISCUSS] Handling correctness/data loss jiras

2018-08-13 Thread Sean Owen
Generally: if someone thinks correctness fix X should be backported further, I'd say just do it, if it's to an active release branch (see below). Anything that important has to outweigh most any other concern, like behavior changes. On Mon, Aug 13, 2018 at 11:08 AM Tom Graves wrote: > I'm not r

Re: [DISCUSS] Handling correctness/data loss jiras

2018-08-13 Thread Imran Rashid
I don't think we've been great about backporting correctness issues. This is one example which comes to mind (not to point fingers, just the one I know of immediately): https://issues.apache.org/jira/browse/SPARK-23207 we also let another related issue slide for quite a while: https://issues.ap

Re: [DISCUSS] Handling correctness/data loss jiras

2018-08-13 Thread Tom Graves
Not a specific jira but was looking at all the recent jiras with the "correctness" label and things are definitely being handled in consistently in my opinion (https://issues.apache.org/jira/issues/?jql=labels+%3D+correctness).    The inconsistencies are in the things I've mentioned above.  Pr

Re: [DISCUSS] Handling correctness/data loss jiras

2018-08-13 Thread Sean Owen
I doubt the question is whether people want to take such issues seriously -- all else equal, of course everyone does. A JIRA label plus place in the release notes sounds like a good concrete step that isn't happening consistently now. That's a clear flag that at least one person believes issue X i

[DISCUSS] Handling correctness/data loss jiras

2018-08-13 Thread Tom Graves
Hello all, I've noticed some inconsistencies in the way we are handling data loss/correctness issues.  I think we need to take these very seriously as they could be causing businesses real money and impacting real decisions and business logic.   I would like to discuss how we can make sure these