Re: Please review (ValidateExternalType should return child in error)

2024-08-28 Thread Mark Andreev
Hi Maksim, I would really appreciate it if you could review my PR [ https://github.com/apache/spark/pull/47522 ]. Would you mind taking a look at my changes? How can I improve my PR flow for a better view from the reviewer's perspective? On Sun, 25 Aug 2024 at 18:18, Mark Andreev wrote:

Re: Please review (ValidateExternalType should return child in error)

2024-08-25 Thread Mark Andreev
Hi Michael, I would really appreciate it if you could review my PR [ https://github.com/apache/spark/pull/47522 ], as your expertise in the SQL part of Apache Spark is invaluable. Would you mind taking a look at my changes? On Sun, 25 Aug 2024 at 18:15, Mark Andreev wrote: > Thank you Bj

Re: Please review (ValidateExternalType should return child in error)

2024-08-25 Thread Mark Andreev
mmunity and committers >>to ensure the PR meets the necessary standards. >>3. Approval: Once approved by committers, the PR can be merged into >>the main codebase. >> >> >> HTH >> >> >> >> On Sun, 25 Aug 2024 at 08:17, Mark Andr

Re: Please review (ValidateExternalType should return child in error)

2024-08-25 Thread Mark Andreev
Thank you for your review. Could you explain how to merge this commit into the upstream? I don't want this PR to be abandoned. Best regards, Mark Andreev On Wed, 21 Aug 2024 at 23:08, Mich Talebzadeh wrote: > Hi Mark, > > You have already done that and have made the requ

Re: Please review (ValidateExternalType should return child in error)

2024-08-21 Thread Mark Andreev
f course cannot be guaranteed . It is essential to note > that, as with any advice, quote "one test result is worth one-thousand > expert opinions (Werner <https://en.wikipedia.org/wiki/Wernher_von_Braun>Von > Braun <https://en.wikipedia.org/wiki/Wernher_von_Braun>)

Re: Please review (ValidateExternalType should return child in error)

2024-08-20 Thread Mark Andreev
schema of string at getexternalrowfield(assertnotnull(input[0, org.apache.spark.sql.Row, true]), 1, f3) If you need more information, please let me know. If you're busy, please let me know the best time to reach you again. On Mon, 29 Jul 2024 at 18:15, Mark Andreev wrote: > Hi Sp

Please review (ValidateExternalType should return child in error)

2024-07-29 Thread Mark Andreev
fter fix: [B is not a valid external type for schema of string at getexternalrowfield(assertnotnull(input[0, org.apache.spark.sql.Row, true]), 1, f3) -- Best regards, Mark Andreev

[Suggest] Add geo function to core

2023-01-06 Thread Mark Andreev
create a separate module (standalone repository out of apache) and after success merge into the main branch? -- Best regards, Mark Andreev