Re: [VOTE] SPIP: Add the TIME data type

2025-02-23 Thread Yang Jie
+1 On 2025/02/24 05:30:34 Jungtaek Lim wrote: > +1 (non-binding) > > On Mon, Feb 24, 2025 at 2:26 PM Gengliang Wang wrote: > > > +1 > > > > On Sun, Feb 23, 2025 at 8:40 PM Hyukjin Kwon wrote: > > > >> +1 > >> > >> On Mon, 24 Feb 2025 at 11:47, Wenchen Fan wrote: > >> > >>> +1 > >>> > >>> On M

Re: [VOTE] Release Spark 3.5.5 (RC1)

2025-02-23 Thread Yang Jie
+1 On 2025/02/24 04:04:22 Dongjoon Hyun wrote: > Thank you for your voting. > > I have been aware of SPARK-51281 since Wenchen pinged me three days ago. > > I just thought it was not going to be ready because the PR was idle for the > last two days after my comment. > > Since SPARK-51281 is not

Re: [VOTE] SPIP: Add the TIME data type

2025-02-23 Thread Jungtaek Lim
+1 (non-binding) On Mon, Feb 24, 2025 at 2:26 PM Gengliang Wang wrote: > +1 > > On Sun, Feb 23, 2025 at 8:40 PM Hyukjin Kwon wrote: > >> +1 >> >> On Mon, 24 Feb 2025 at 11:47, Wenchen Fan wrote: >> >>> +1 >>> >>> On Mon, Feb 24, 2025 at 7:51 AM John Zhuge wrote: >>> +1 (non-binding)

Re: [VOTE] SPIP: Add the TIME data type

2025-02-23 Thread Gengliang Wang
+1 On Sun, Feb 23, 2025 at 8:40 PM Hyukjin Kwon wrote: > +1 > > On Mon, 24 Feb 2025 at 11:47, Wenchen Fan wrote: > >> +1 >> >> On Mon, Feb 24, 2025 at 7:51 AM John Zhuge wrote: >> >>> +1 (non-binding) >>> >>> John Zhuge >>> >>> >>> On Sun, Feb 23, 2025 at 2:37 PM huaxin gao >>> wrote: >>> >>>

Re: [VOTE] SPIP: Add the TIME data type

2025-02-23 Thread Hyukjin Kwon
+1 On Mon, 24 Feb 2025 at 11:47, Wenchen Fan wrote: > +1 > > On Mon, Feb 24, 2025 at 7:51 AM John Zhuge wrote: > >> +1 (non-binding) >> >> John Zhuge >> >> >> On Sun, Feb 23, 2025 at 2:37 PM huaxin gao >> wrote: >> >>> +1 >>> >>> On Sun, Feb 23, 2025 at 1:51 PM serge rielau.com >>> wrote: >>>

Re: [VOTE] Release Spark 4.0.0 (RC1)

2025-02-23 Thread Wenchen Fan
This vote failed. I'll cut RC2 later this week. Thanks to everyone for participating! On Sat, Feb 22, 2025 at 12:53 AM Max Gekk wrote: > -1, need a proper error message for not fully implemented feature: > https://issues.apache.org/jira/browse/SPARK-51289 > > On Fri, Feb 21, 2025 at 4:11 PM Adam

Re: [VOTE] Release Spark 3.5.5 (RC1)

2025-02-23 Thread Dongjoon Hyun
Thank you for your voting. I have been aware of SPARK-51281 since Wenchen pinged me three days ago. I just thought it was not going to be ready because the PR was idle for the last two days after my comment. Since SPARK-51281 is not a release blocker of Apache Spark 3.5.5 RC1 vote because - it's

Re: [VOTE] SPIP: Add the TIME data type

2025-02-23 Thread Wenchen Fan
+1 On Mon, Feb 24, 2025 at 7:51 AM John Zhuge wrote: > +1 (non-binding) > > John Zhuge > > > On Sun, Feb 23, 2025 at 2:37 PM huaxin gao wrote: > >> +1 >> >> On Sun, Feb 23, 2025 at 1:51 PM serge rielau.com >> wrote: >> >>> +1 it’s abt time. >>> Sent from my iPhone >>> >>> > On Feb 23, 2025, a

Re: [VOTE] Release Spark 3.5.5 (RC1)

2025-02-23 Thread Wenchen Fan
-0 as I just found a long-standing correctness bug: https://github.com/apache/spark/pull/50040 It's not a regression in 3.5 so technically it's not a release blocker, but it's better to include it as we are just about to release 3.5.5. On Mon, Feb 24, 2025 at 9:11 AM Mich Talebzadeh wrote: > +1

Re: [VOTE] Release Spark 3.5.5 (RC1)

2025-02-23 Thread Mich Talebzadeh
+1 on the basis of Dongjoon statement which I trust HTH Dr Mich Talebzadeh, Architect | Data Science | Financial Crime | Forensic Analysis | GDPR view my Linkedin profile On Mon, 24 Feb 2025 at 00:47, Dongjoon Hyun wrote: > I'l

Re: [VOTE] Release Spark 3.5.5 (RC1)

2025-02-23 Thread Dongjoon Hyun
I'll start with my +1. I have thoroughly verified all test results, signatures, checksums, and the recently deprecated configuration. Dongjoon. On 2025/02/24 00:37:57 Dongjoon Hyun wrote: > Please vote on releasing the following candidate as Apache Spark version > 3.5.5. > > The vote is open u

[VOTE] Release Spark 3.5.5 (RC1)

2025-02-23 Thread Dongjoon Hyun
Please vote on releasing the following candidate as Apache Spark version 3.5.5. The vote is open until February 27th 1AM (PST) and passes if a majority +1 PMC votes are cast, with a minimum of 3 +1 votes. [ ] +1 Release this package as Apache Spark 3.5.5 [ ] -1 Do not release this package because

Re: [VOTE] SPIP: Add the TIME data type

2025-02-23 Thread John Zhuge
+1 (non-binding) John Zhuge On Sun, Feb 23, 2025 at 2:37 PM huaxin gao wrote: > +1 > > On Sun, Feb 23, 2025 at 1:51 PM serge rielau.com wrote: > >> +1 it’s abt time. >> Sent from my iPhone >> >> > On Feb 23, 2025, at 12:25 PM, L. C. Hsieh wrote: >> > >> > +1 >> > >> >> On Sun, Feb 23, 2025

Re: [VOTE] SPIP: Add the TIME data type

2025-02-23 Thread huaxin gao
+1 On Sun, Feb 23, 2025 at 1:51 PM serge rielau.com wrote: > +1 it’s abt time. > Sent from my iPhone > > > On Feb 23, 2025, at 12:25 PM, L. C. Hsieh wrote: > > > > +1 > > > >> On Sun, Feb 23, 2025 at 7:51 AM Max Gekk wrote: > >> > >> Hi Spark devs, > >> > >> Following the discussion [1], I'd

Re: [VOTE] SPIP: Add the TIME data type

2025-02-23 Thread serge rielau . com
+1 it’s abt time. Sent from my iPhone > On Feb 23, 2025, at 12:25 PM, L. C. Hsieh wrote: > > +1 > >> On Sun, Feb 23, 2025 at 7:51 AM Max Gekk wrote: >> >> Hi Spark devs, >> >> Following the discussion [1], I'd like to start the vote for the SPIP [2]. >> The SPIP aims to add a new data typ

Re: [VOTE] SPIP: Add the TIME data type

2025-02-23 Thread L. C. Hsieh
+1 On Sun, Feb 23, 2025 at 7:51 AM Max Gekk wrote: > > Hi Spark devs, > > Following the discussion [1], I'd like to start the vote for the SPIP [2]. > The SPIP aims to add a new data type TIME to Spark SQL types. New type should > conform to TIME(n) WITHOUT TIME ZONE as defined by the SQL stand

Re: [VOTE] SPIP: Add the TIME data type

2025-02-23 Thread Fokko Driesprong
+1 (non-binding) Thanks Max! Kind regards, Fokko Op zo 23 feb 2025 om 19:35 schreef Ángel : > + 1 (non-binding) > > El dom, 23 feb 2025, 16:51, Max Gekk escribió: > >> Hi Spark devs, >> >> Following the discussion [1], I'd like to start the vote for the SPIP >> [2]. The SPIP aims to add a new

Re: [VOTE] SPIP: Add the TIME data type

2025-02-23 Thread Ángel
+ 1 (non-binding) El dom, 23 feb 2025, 16:51, Max Gekk escribió: > Hi Spark devs, > > Following the discussion [1], I'd like to start the vote for the SPIP [2]. > The SPIP aims to add a new data type TIME to Spark SQL types. New type > should conform to TIME(n) WITHOUT TIME ZONE as defined by th

Re: [VOTE] SPIP: Add the TIME data type

2025-02-23 Thread Jules Damji
+ 1 (non-binding) Excuse the thumb typos On Sun, 23 Feb 2025 at 7:50 AM, Max Gekk wrote: > Hi Spark devs, > > Following the discussion [1], I'd like to start the vote for the SPIP [2]. > The SPIP aims to add a new data type TIME to Spark SQL types. New type > should conform to TIME(n) WITHOUT

Re: [VOTE] SPIP: Add the TIME data type

2025-02-23 Thread Reynold Xin
+1 On Sun, Feb 23, 2025 at 7:51 AM Max Gekk wrote: > Hi Spark devs, > > Following the discussion [1], I'd like to start the vote for the SPIP [2]. > The SPIP aims to add a new data type TIME to Spark SQL types. New type > should conform to TIME(n) WITHOUT TIME ZONE as defined by the SQL > standa

Re: [VOTE] SPIP: Add the TIME data type

2025-02-23 Thread Mich Talebzadeh
+1 for me following my recent comments on the discussion thread on this topic as well Dr Mich Talebzadeh, Architect | Data Science | Financial Crime | Forensic Analysis | GDPR view my Linkedin profile On Sun, 23 Feb 2025 at 17:16,

Re: [DISCUSS] SPIP: Add the TIME data type

2025-02-23 Thread Mich Talebzadeh
Hi Max, I saw the vote on this topic so let us conclude this discussion. Actually Oracle does not support this TIME data type but Google BigQuery does support it. if i was going to argue in favour of having it in Spark SQL, I would consider the following as part of cost/benefit analysis: Perform

Re: [VOTE] SPIP: Add the TIME data type

2025-02-23 Thread Dongjoon Hyun
+1 Thank you, Max. Dongjoon. On 2025/02/23 15:49:58 Max Gekk wrote: > Hi Spark devs, > > Following the discussion [1], I'd like to start the vote for the SPIP [2]. > The SPIP aims to add a new data type TIME to Spark SQL types. New type > should conform to TIME(n) WITHOUT TIME ZONE as defined b

Re: [VOTE][RESULT] Release Apache Spark 3.5.5 deprecating `spark.databricks.*` configuration

2025-02-23 Thread Dongjoon Hyun
I made an error while counting the bindings manually. I missed Max Gekk's binding. The corrected count is "7 binding +1s" instead of "6 binding +1s". I sincerely apologize for my mistake, Max. https://projects.apache.org/committee.html?spark The vote passes with 17 +1s (7 binding +1s). Thanks to

[VOTE] SPIP: Add the TIME data type

2025-02-23 Thread Max Gekk
Hi Spark devs, Following the discussion [1], I'd like to start the vote for the SPIP [2]. The SPIP aims to add a new data type TIME to Spark SQL types. New type should conform to TIME(n) WITHOUT TIME ZONE as defined by the SQL standard. This thread will be open for at least the next 72 hours. Ple