Re: [DISCUSS] Move Variant to Parquet?

2024-08-25 Thread Gang Wu
Hi, There is a relevant discussion in the dev@parquet: https://lists.apache.org/thread/6h58hj39lhqtcyd2hlsyvqm4lzdh4b9z The feedback looks promising. Looking forward to cooperating with the Spark community! Best regards, Gang On Thu, Aug 22, 2024 at 10:20 PM Eduard Tudenhöfner < etudenhoef...@a

Re: Structured Streaming Programming Guide Improvements + Versionless Docs Update

2024-08-25 Thread Neil Ramaswamy
Awesome, I'm glad that others think this is a good idea. I'd love a review of the initial splitting apart PR if you have a chance. And I have plans to break up the guide and refine the content even further; my personal Structured Streaming docs site

Re: Structured Streaming Programming Guide Improvements + Versionless Docs Update

2024-08-25 Thread Anish Shrigondekar
+1 - I think it would be super helpful to split this single long doc. Couple of points that might be useful: - If we could create an individual page per operator with some concrete examples, that would be great - As Jungtaek mentioned, separating the API reference from the conceptual portions migh

Re: Structured Streaming Programming Guide Improvements + Versionless Docs Update

2024-08-25 Thread Jungtaek Lim
Sorry for the late reply. I'm strongly supportive about the initial movement, splitting a crazy long one page of guide doc into multiple pages. If anyone ever looks at the SS guide doc page, they would agree that anyone can't simply say "RTFM" to learn about SS or use the page as reference. The Ch

[VOTE][RESULT] Deprecate SparkR

2024-08-25 Thread Hyukjin Kwon
This vote passed with 19 +1s (12 bindings, * = binding): +1: Reynold Xin (*) Sean Owen (*) Denny Lee Mridul Muralidharan (*) Xiangrui Meng (*) Martin Grund Herman van Hovell (*) Holden Karau (*) Dongjoon Hyun (*) Hyukjin Kwon (*) Xiao Li (*) Jungtaek Lim Zhou Jiang Allison Wang Yuming Wang (*) Cha

Re: Please review (ValidateExternalType should return child in error)

2024-08-25 Thread Mark Andreev
Hi Michael, I would really appreciate it if you could review my PR [ https://github.com/apache/spark/pull/47522 ], as your expertise in the SQL part of Apache Spark is invaluable. Would you mind taking a look at my changes? On Sun, 25 Aug 2024 at 18:15, Mark Andreev wrote: > Thank you Bjørn.

Re: Please review (ValidateExternalType should return child in error)

2024-08-25 Thread Mark Andreev
Thank you Bjørn. My PR [ https://github.com/apache/spark/pull/47522 ] was updated to be aligned with the guideline. + What changes were proposed in this pull request? + Why are the changes needed? + Does this PR introduce any user-facing change? + How was this patch tested? + Was this patch autho

Re: Please review (ValidateExternalType should return child in error)

2024-08-25 Thread Bjørn Jørgensen
Apache spark does have a template for PR's https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE søn. 25. aug. 2024 kl. 13:41 skrev Mich Talebzadeh < mich.talebza...@gmail.com>: > Unfortunately it is not that straight forward > > >1. Committer Votes: The PR needs a suffici

Re: Please review (ValidateExternalType should return child in error)

2024-08-25 Thread Mich Talebzadeh
Unfortunately it is not that straight forward 1. Committer Votes: The PR needs a sufficient number of "+1" votes from *committers.* 2. Review Process: Address feedback from the community and committers to ensure the PR meets the necessary standards. 3. Approval: Once approved by co

Re: Please review (ValidateExternalType should return child in error)

2024-08-25 Thread Mark Andreev
Thank you for your review. Could you explain how to merge this commit into the upstream? I don't want this PR to be abandoned. Best regards, Mark Andreev On Wed, 21 Aug 2024 at 23:08, Mich Talebzadeh wrote: > Hi Mark, > > You have already done that and have made the request for review. > > +1