Re: [DISCUSS] Allow GitHub Actions runs for contributors' PRs without approvals in apache/spark-connect-go

2024-07-03 Thread Martin Grund
Absolutely we should do that. I thought that the default rule was inclusive already so that once folks have their first contribution it would automatically allow kicking of the workflows. On Thu, Jul 4, 2024 at 04:20 Matthew Powers wrote: > Yea, this would be great. > > spark-connect-go is still

Re: [VOTE] Move Spark Connect server to builtin package (Client API layer stays external)

2024-07-03 Thread John Zhuge
+1 John Zhuge On Wed, Jul 3, 2024 at 7:41 PM Gengliang Wang wrote: > +1 > > On Wed, Jul 3, 2024 at 4:48 PM Reynold Xin > wrote: > >> +1 >> >> On Wed, Jul 3, 2024 at 4:45 PM L. C. Hsieh wrote: >> >>> +1 >>> >>> On Wed, Jul 3, 2024 at 3:54 PM Dongjoon Hyun >>> wrote: >>> > >>> > +1 >>> > >>>

Re: [VOTE] Move Spark Connect server to builtin package (Client API layer stays external)

2024-07-03 Thread Chao Sun
+1 On Wed, Jul 3, 2024 at 6:24 PM Jungtaek Lim wrote: > +1 (non-binding) > > Thanks! > > On Thu, Jul 4, 2024 at 8:48 AM Reynold Xin > wrote: > >> +1 >> >> On Wed, Jul 3, 2024 at 4:45 PM L. C. Hsieh wrote: >> >>> +1 >>> >>> On Wed, Jul 3, 2024 at 3:54 PM Dongjoon Hyun >>> wrote: >>> > >>> > +1

Re: [VOTE] Move Spark Connect server to builtin package (Client API layer stays external)

2024-07-03 Thread Wenchen Fan
+1 On Thu, Jul 4, 2024 at 10:41 AM Gengliang Wang wrote: > +1 > > On Wed, Jul 3, 2024 at 4:48 PM Reynold Xin > wrote: > >> +1 >> >> On Wed, Jul 3, 2024 at 4:45 PM L. C. Hsieh wrote: >> >>> +1 >>> >>> On Wed, Jul 3, 2024 at 3:54 PM Dongjoon Hyun >>> wrote: >>> > >>> > +1 >>> > >>> > Dongjoon >

Re: [DISCUSS] Allow GitHub Actions runs for contributors' PRs without approvals in apache/spark-connect-go

2024-07-03 Thread Matthew Powers
Yea, this would be great. spark-connect-go is still experimental and anything we can do to get it production grade would be a great step IMO. The Go community is excited to write Spark... with Go! On Wed, Jul 3, 2024 at 8:49 PM Hyukjin Kwon wrote: > Hi all, > > The Spark Connect Go client repo

[DISCUSS] Allow GitHub Actions runs for contributors' PRs without approvals in apache/spark-connect-go

2024-07-03 Thread Hyukjin Kwon
Hi all, The Spark Connect Go client repository ( https://github.com/apache/spark-connect-go) requires GitHub Actions runs for individual commits within contributors' PRs. This policy was intentionally applied ( https://issues.apache.org/jira/browse/INFRA-24387), but we can change this default onc

Re: [VOTE] Move Spark Connect server to builtin package (Client API layer stays external)

2024-07-03 Thread Jungtaek Lim
+1 (non-binding) Thanks! On Thu, Jul 4, 2024 at 8:48 AM Reynold Xin wrote: > +1 > > On Wed, Jul 3, 2024 at 4:45 PM L. C. Hsieh wrote: > >> +1 >> >> On Wed, Jul 3, 2024 at 3:54 PM Dongjoon Hyun >> wrote: >> > >> > +1 >> > >> > Dongjoon >> > >> > On Wed, Jul 3, 2024 at 10:58 Xinrong Meng wrote

Re: [VOTE] Move Spark Connect server to builtin package (Client API layer stays external)

2024-07-03 Thread Gengliang Wang
+1 On Wed, Jul 3, 2024 at 4:48 PM Reynold Xin wrote: > +1 > > On Wed, Jul 3, 2024 at 4:45 PM L. C. Hsieh wrote: > >> +1 >> >> On Wed, Jul 3, 2024 at 3:54 PM Dongjoon Hyun >> wrote: >> > >> > +1 >> > >> > Dongjoon >> > >> > On Wed, Jul 3, 2024 at 10:58 Xinrong Meng wrote: >> >> >> >> +1 >> >>

Re: [VOTE] Move Spark Connect server to builtin package (Client API layer stays external)

2024-07-03 Thread Reynold Xin
+1 On Wed, Jul 3, 2024 at 4:45 PM L. C. Hsieh wrote: > +1 > > On Wed, Jul 3, 2024 at 3:54 PM Dongjoon Hyun > wrote: > > > > +1 > > > > Dongjoon > > > > On Wed, Jul 3, 2024 at 10:58 Xinrong Meng wrote: > >> > >> +1 > >> > >> Thank you @Hyukjin Kwon ! > >> > >> On Wed, Jul 3, 2024 at 8:55 AM bo

Re: [VOTE] Move Spark Connect server to builtin package (Client API layer stays external)

2024-07-03 Thread L. C. Hsieh
+1 On Wed, Jul 3, 2024 at 3:54 PM Dongjoon Hyun wrote: > > +1 > > Dongjoon > > On Wed, Jul 3, 2024 at 10:58 Xinrong Meng wrote: >> >> +1 >> >> Thank you @Hyukjin Kwon ! >> >> On Wed, Jul 3, 2024 at 8:55 AM bo yang wrote: >>> >>> +1 (non-binding) >>> >>> >>> On Tue, Jul 2, 2024 at 11:22 PM Cheng

Re: [VOTE] Move Spark Connect server to builtin package (Client API layer stays external)

2024-07-03 Thread Dongjoon Hyun
+1 Dongjoon On Wed, Jul 3, 2024 at 10:58 Xinrong Meng wrote: > +1 > > Thank you @Hyukjin Kwon ! > > On Wed, Jul 3, 2024 at 8:55 AM bo yang wrote: > >> +1 (non-binding) >> > >> On Tue, Jul 2, 2024 at 11:22 PM Cheng Pan wrote: >> >>> +1 (non-binding) >>> >>> Thanks, >>> Cheng Pan >>> >>> >>> O

Re: [VOTE] Move Spark Connect server to builtin package (Client API layer stays external)

2024-07-03 Thread Matthew Powers
+1 (non-binding) Thanks! On Wed, Jul 3, 2024 at 1:58 PM Xinrong Meng wrote: > +1 > > Thank you @Hyukjin Kwon ! > > On Wed, Jul 3, 2024 at 8:55 AM bo yang wrote: > >> +1 (non-binding) >> >> On Tue, Jul 2, 2024 at 11:22 PM Cheng Pan wrote: >> >>> +1 (non-binding) >>> >>> Thanks, >>> Cheng Pan

Re: [VOTE] Move Spark Connect server to builtin package (Client API layer stays external)

2024-07-03 Thread Takuya UESHIN
+1 On Wed, Jul 3, 2024 at 10:58 AM Xinrong Meng wrote: > +1 > > Thank you @Hyukjin Kwon ! > > On Wed, Jul 3, 2024 at 8:55 AM bo yang wrote: > >> +1 (non-binding) >> >> On Tue, Jul 2, 2024 at 11:22 PM Cheng Pan wrote: >> >>> +1 (non-binding) >>> >>> Thanks, >>> Cheng Pan >>> >>> >>> On Jul 3,

Re: [VOTE] Move Spark Connect server to builtin package (Client API layer stays external)

2024-07-03 Thread Xinrong Meng
+1 Thank you @Hyukjin Kwon ! On Wed, Jul 3, 2024 at 8:55 AM bo yang wrote: > +1 (non-binding) > > On Tue, Jul 2, 2024 at 11:22 PM Cheng Pan wrote: > >> +1 (non-binding) >> >> Thanks, >> Cheng Pan >> >> >> On Jul 3, 2024, at 08:59, Hyukjin Kwon wrote: >> >> Hi all, >> >> I’d like to start a v

Re: Deploying Spark on Kubernetes Operator

2024-07-03 Thread L. C. Hsieh
Thanks for being interested in the Spark Kubernetes Operator. Because the initial PR is large so it is split into several PRs which are good to review and merge. And seems the initial series of PRs to merge the codes into the repo is not done yet. For example, you can see there is PR to add the op

Re: [VOTE] Move Spark Connect server to builtin package (Client API layer stays external)

2024-07-03 Thread bo yang
+1 (non-binding) On Tue, Jul 2, 2024 at 11:22 PM Cheng Pan wrote: > +1 (non-binding) > > Thanks, > Cheng Pan > > > On Jul 3, 2024, at 08:59, Hyukjin Kwon wrote: > > Hi all, > > I’d like to start a vote for moving Spark Connect server to builtin > package (Client API layer stays external). > > P