Re: Live Streamed Code Review today at 11am Pacific

I'll be doing another one tomorrow morning at 9am pacific focused on Python + K8s support & improved JSON support - https://www.youtube.com/watch?v=Z7ZEkvNwneU & https://www.twitch.tv/events/xU90q9RGRGSOgp2LoNsf6A :) On Fri, Mar 9, 2018 at 3:54 PM, Holden Karau wrote: > If anyone wants to watch

Re: Scala 2.12 support

When I updated for Scala 2.12, I was able to remove almost all the 2.11-2.12 differences. There are still already two source trees for 2.11 vs 2.12. I mean that if it's necessary to accommodate differences between the two, it's already set up for that, and there aren't a mess of differences to patc

Re: Scala 2.12 support

It is from the most recent 2.11 I don’t try it yet on 2.12, but I expect to get the same result. On Thu, Jun 7, 2018 at 6:28 PM Wenchen Fan wrote: > One more point: There was a time that we maintain 2 Spark REPL codebase > for Scala 2.10 and 2.11, maybe we can do the same for Scala 2.11 and 2.1

Re: Scala 2.12 support

One more point: There was a time that we maintain 2 Spark REPL codebase for Scala 2.10 and 2.11, maybe we can do the same for Scala 2.11 and 2.12? if it's too hard to find a common way to do that between different Scala versions. On Thu, Jun 7, 2018 at 6:20 PM, Marcelo Vanzin wrote: > But DB's s

Re: Scala 2.12 support

But DB's shell output is on the most recent 2.11, not 2.12, right? On Thu, Jun 7, 2018 at 5:54 PM, Holden Karau wrote: > I agree that's a little odd, could we not add the bacspace terminal > character? Regardless even if not, I don't think that should be a blocker > for 2.12 support especially si

Re: Scala 2.12 support

I agree that's a little odd, could we not add the bacspace terminal character? Regardless even if not, I don't think that should be a blocker for 2.12 support especially since it doesn't degrade the 2.11 experience. On Thu, Jun 7, 2018, 5:53 PM DB Tsai wrote: > If we decide to initialize Spark i

Re: Scala 2.12 support

If we decide to initialize Spark in `initializeSynchronous()` in Scala 2.11.12, it will look like the following which is odd. Using Scala version 2.11.12 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_161) Type in expressions to have them evaluated. Type :help for more information. scala> Spark

Re: Scala 2.12 support

Tests can just be changed to accept either output too :p On Thu, Jun 7, 2018, 5:19 PM Dean Wampler wrote: > Do the tests expect a particular console output order? That would annoy > them. ;) You could sort the expected and output lines, then diff... > > > *Dean Wampler, Ph.D.* > > *VP, Fast Data

Re: Scala 2.12 support

Do the tests expect a particular console output order? That would annoy them. ;) You could sort the expected and output lines, then diff... *Dean Wampler, Ph.D.* *VP, Fast Data Engineering at Lightbend* Author: Programming Scala, 2nd Edition , Fa

Re: Scala 2.12 support

If the difference is the order of the welcome message I think that should be fine. On Thu, Jun 7, 2018, 4:43 PM Dean Wampler wrote: > I'll point the Scala team to this issue, but it's unlikely to get fixed > any time soon. > > dean > > > *Dean Wampler, Ph.D.* > > *VP, Fast Data Engineering at Li

Re: Scala 2.12 support

I'll point the Scala team to this issue, but it's unlikely to get fixed any time soon. dean *Dean Wampler, Ph.D.* *VP, Fast Data Engineering at Lightbend* Author: Programming Scala, 2nd Edition , Fast Data Architectures for Streaming Application

Re: Scala 2.12 support

Thanks Felix for bringing this up. Currently, in Scala 2.11.8, we initialize the Spark by overriding loadFIles() before REPL sees any file since there is no good hook in Scala to load our initialization code. In Scala 2.11.12 and newer version of the Scala 2.12.x, loadFIles() method was remove

Re: Time for 2.2.2 release

Took a look at our branch and most of the stuff that is not already in 2.2 are flaky test fixes, so +1. On Wed, Jun 6, 2018 at 7:54 AM, Tom Graves wrote: > Hello all, > > I think its time for another 2.2 release. > I took a look at Jira and I don't see anything explicitly targeted for 2.2.2 > tha

Re: Scala 2.12 support

+1 Spoke to Dean as well and mentioned the problem with 2.11.12 https://github.com/scala/bug/issues/10913 _ From: Sean Owen Sent: Wednesday, June 6, 2018 12:23 PM Subject: Re: Scala 2.12 support To: Holden Karau Cc: Dean Wampler , Reynold Xin , dev If it means n

Re: Time for 2.2.2 release

+1 and thanks! From: Tom Graves Sent: Wednesday, June 6, 2018 7:54:43 AM To: Dev Subject: Time for 2.2.2 release Hello all, I think its time for another 2.2 release. I took a look at Jira and I don't see anything explicitly targeted for 2.2.2 that is not yet co