Re: DataFrame API and Ordering

2016-02-19 Thread Maciej Szymkiewicz
I am not sure. Spark SQL, DataFrames and Datasets Guide already has a section about NaN semantics. This could be a good place to add at least some basic description. For the rest InterpretedOrdering could be a good choice. On 02/19/2016 12:35 AM, Reynold Xin wrote: > You are correct and we should

Re: pull request template

2016-02-19 Thread Reynold Xin
We can add that too - just need to figure out a good way so people don't leave a lot of the unnecessary "guideline" messages in the template. The contributing guide is great, but unfortunately it is not as noticeable and is often ignored. It's good to have this full-fledged contributing guide, and

Re: How to run PySpark tests?

2016-02-19 Thread Holden Karau
Or wait I don't have access to the wiki - if anyone can give me wiki access I'll update the instructions. On Thu, Feb 18, 2016 at 8:45 PM, Holden Karau wrote: > Great - I'll update the wiki. > > On Thu, Feb 18, 2016 at 8:34 PM, Jason White > wrote: > >> Compiling with `build/mvn -Pyarn -Phadoop

Re: Write access to wiki

2016-02-19 Thread Holden Karau
Any chance I could also get write access to the wiki? I'd like to update some of the PySpark documentation in the wiki. On Tue, Jan 12, 2016 at 10:14 AM, shane knapp wrote: > > Ok, sounds good. I think it would be great, if you could add installing > the > > 'docker-engine' package and starting

Re: pull request template

2016-02-19 Thread Sean Owen
All that seems fine. All of this is covered in the contributing wiki, which is linked from CONTRIBUTING.md (and should be from the template), but people don't seem to bother reading it. I don't mind duplicating some key points, and even a more explicit exhortation to read the whole wiki, before con

Re: pull request template

2016-02-19 Thread Iulian DragoČ™
It's a good idea. I would add in there the spec for the PR title. I always get wrong the order between Jira and component. Moreover, CONTRIBUTING.md is also lacking them. Any reason not to add it there? I can open PRs for both, but maybe you want to keep that info on the wiki instead. iulian On