anchela commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1388024166
##
src/test/java/org/apache/sling/jcr/repoinit/GeneralAclTest.java:
##
@@ -270,9 +270,9 @@ private void verifyRegisterNamespace(String username
rombert opened a new pull request, #40:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/40
…ml classes
Mark org.owasp.html as a private-package so that it is included in the jar
file. Use 'merge-first' since we provide classes in our own project. We don't
overwrite any
rombert commented on PR #40:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/40#issuecomment-1803866476
Manual checks for the generated jar
```
$ jar tf target/org.apache.sling.xss-2.3.11-SNAPSHOT.jar | grep -E -c
'owasp/html/.*.class'
117
$ jar tf target/org.
sonarcloud[bot] commented on PR #40:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/40#issuecomment-1803869680
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
rmcdouga commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1803926586
Thank you for doing that and walking me through the process. I will
structure my commit comments like that in the future.
--
This is an automated message fr
rombert commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1803933132
All good, thanks for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jsedding commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1388150998
##
src/test/java/org/apache/sling/jcr/repoinit/GeneralAclTest.java:
##
@@ -270,9 +270,9 @@ private void verifyRegisterNamespace(String usernam
jsedding commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1804022381
Thank you for your reviews, @anchela! Addressing the points you raised
forced me to look at all the details again, and I believe the result is an
improvement ove
rombert commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1388291023
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -174,9 +173,26 @@ private static void setAcl(Session session, List
pri
jsedding commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1389007296
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -174,9 +173,26 @@ private static void setAcl(Session session, List
pr
jsedding commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1805221195
@anchela in order to clear your "changes request" status from the PR, I
clicked the "re-request review" icon. Should have done that yesterday, before
you reviewe
jsedding merged PR #45:
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-u
rombert merged PR #39:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
rombert merged PR #40:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
rmcdouga opened a new pull request, #3:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/3
org.apache.sling.testing.sling-mock 1.8.0->3.4.14
org.apache.sling:sling 47->52
--
This is an automated message from the Apache Git Service.
To respond to the message, p
rombert opened a new pull request, #6:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/6
Add a servlet that uses the Jakarta JSON APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
rombert opened a new pull request, #17:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/17
Add a test that uses the Jakarta JSON test service
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
rombert commented on PR #17:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/17#issuecomment-1805729792
Must be merged after
https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/6
--
This is an automated message from the Apa
cziegeler merged PR #40:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubs
sonarcloud[bot] commented on PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/6#issuecomment-1805793798
SonarCloud Quality Gate failed. [](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Co
rombert merged PR #146:
URL: https://github.com/apache/sling-site/pull/146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.
renovate-bot opened a new pull request, #272:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/272
[](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Ado
renovate-bot opened a new pull request, #273:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/273
[](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Ado
rombert merged PR #273:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
rombert closed pull request #272: chore(deps): update dependency
org.apache.sling:org.apache.sling.resourceresolver to v1.11.2
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/272
--
This is an automated message from the Apache Git Service.
To respond to the message, please
rombert commented on PR #272:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/272#issuecomment-1809868535
Will wait for the follow-up 1.11.4 release -
https://lists.apache.org/thread/f8c4x9r0o0fg54rm1q0mf1wmcm715s01 .
--
This is an automated message from the Apache Git
forking-renovate[bot] commented on PR #272:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/272#issuecomment-1809868910
### Renovate Ignore Notification
Because you closed this PR without merging, Renovate will ignore this update
(`1.11.2`). You will get a PR once
rombert merged PR #271:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
stefanseifert commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/31#issuecomment-1809987488
thanks for this PR! some comments:
* updating the testing dependencies junit and and mockito is an non-brainer
and should be done immediately
rmcdouga commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/31#issuecomment-1810126968
OK, I will split up the changes into multiple PRs as requested.
I'm not sure I agree with the idea of using older dependency versions for
compatibili
stefanseifert commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/31#issuecomment-1810204110
> I'm not sure I agree with the idea of using older dependency versions for
compatibility with older downstream product versions. Older versions of
[s
renovate-bot opened a new pull request, #274:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/274
[](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Ado
rmcdouga commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/31#issuecomment-1810370859
> in general i'm completely on your side, but if you are e.g. stuck in an
older AEM 6.5 project, you are bound to work with a certain set of outdated
3rdpa
rombert merged PR #274:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
sonarcloud[bot] commented on PR #81:
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/81#issuecomment-1810713081
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/p
sonarcloud[bot] commented on PR #84:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84#issuecomment-1811090786
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGat
sonarcloud[bot] commented on PR #78:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/78#issuecomment-1811093184
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/
klcodanr opened a new pull request, #275:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/275
Currently returns a 404 due to the proxy not being configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
cziegeler closed pull request #25: SLING-9745 Sling Uri Mapping SPI
URL: https://github.com/apache/sling-org-apache-sling-api/pull/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
cziegeler closed pull request #22: SLING-9662 Introduce Resource Mapping SPI
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
cziegeler closed pull request #6: Feature/sling 9662 introduce sling uri
mapping spi v3
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
rombert merged PR #81:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubs
rmcdouga opened a new pull request, #32:
URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/32
Broken into a separate PR,
Removed commons-lang in favour of more recent commons-lang3.
I plan to update this in the other mock projects to 3.13.0 as well
rmcdouga opened a new pull request, #36:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/36
Bump commons-lang3 3.9->3.13.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-fsresource/pull/2#issuecomment-1812497569
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/p
sonarcloud[bot] commented on PR #32:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/32#issuecomment-1812499729
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityG
sonarcloud[bot] commented on PR #36:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/36#issuecomment-1812500227
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGa
klcodanr merged PR #275:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsu
jsedding commented on code in PR #20:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/20#discussion_r1394490078
##
pom.xml:
##
@@ -34,12 +34,10 @@
Runs JUnit tests in an OSGi framework and provides the JUnit
libraries
-4.13
+
jsedding opened a new pull request, #37:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/37
- OsgiServiceUtilBindUnbindTest seems to have worked around this issue,
hence the change
- factored out "registerDSComponent" in order to reduce code duplication
- w
sonarcloud[bot] commented on PR #37:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/37#issuecomment-1812938063
Kudos, SonarCloud Quality Gate passed! [