Re: [PR] Fix NPE when principal is null in DefaultLdapRealm (#2066)

2025-04-04 Thread 심지연
Hi Lenny and Apache Shiro community, Thank you for your review and feedback. Following your suggestion, I have created the corresponding GitHub issue: - Issue Link: https://github.com/apache/shiro/issues/2069 I have also updated the pull request description to reference the issue properly with `

Re: [PR] Fix NPE when principal is null in DefaultLdapRealm (#2066)

2025-04-04 Thread Lenny Primak
Thanks for your PR. Can you please file the GitHub issue as well? We appreciate it. > On Apr 4, 2025, at 11:01 AM, 심지연 <9305...@gmail.com> wrote: > > Hi Apache Shiro community. > > I hope you are doing well. > > I have submitted a pull request to fix a potential NullPointerException > (NPE

[PR] Fix NPE when principal is null in DefaultLdapRealm (#2066)

2025-04-04 Thread 심지연
Hi Apache Shiro community. I hope you are doing well. I have submitted a pull request to fix a potential NullPointerException (NPE) in `DefaultLdapRealm#getLdapPrincipal`, where the `AuthenticationToken`'s principal could be null. Additionally, I updated the JavaDoc to clarify this behavior and a