Re: [VOTE] SEP-12: Integration Test Framework

2018-05-17 Thread Xinyu Liu
+1 The proposal looks great to me. Look forward to seeing the implementation. Thanks, Xinyu On Wed, May 16, 2018 at 6:12 PM, Sanil Jain wrote: > Hi All, > > This is a call for a vote for Samza's Integration Test Framework as > described by: > > https://cwiki.apache.org/confluence/display/SAMZA

Re: [VOTE] SEP-12: Integration Test Framework

2018-05-17 Thread Daniel Nishimura
+1 Looks great! On Thu, May 17, 2018 at 9:08 AM, Xinyu Liu wrote: > +1 > > The proposal looks great to me. Look forward to seeing the implementation. > > Thanks, > Xinyu > > On Wed, May 16, 2018 at 6:12 PM, Sanil Jain > wrote: > > > Hi All, > > > > This is a call for a vote for Samza's Integra

Re: [VOTE] SEP-12: Integration Test Framework

2018-05-17 Thread Jagadish Venkatraman
Thanks Sanil for the proposal. This will go a long way in simplifying testing of Samza applications. +1 (binding) On Thu, May 17, 2018 at 9:45 AM, Daniel Nishimura wrote: > +1 > > Looks great! > > On Thu, May 17, 2018 at 9:08 AM, Xinyu Liu wrote: > > > +1 > > > > The proposal looks great to

Re: [VOTE] SEP-12: Integration Test Framework

2018-05-17 Thread Jacob Maes
+1 On Thu, May 17, 2018 at 9:56 AM, Jagadish Venkatraman < jagadish1...@gmail.com> wrote: > Thanks Sanil for the proposal. This will go a long way in simplifying > testing of Samza applications. > > +1 (binding) > > > > On Thu, May 17, 2018 at 9:45 AM, Daniel Nishimura > wrote: > > > +1 > > > >

Re: [VOTE] SEP-12: Integration Test Framework

2018-05-17 Thread Navina Ramesh
+1 can't wait to have this in! :) From: Jacob Maes Sent: Thursday, May 17, 2018 10:13:57 AM To: dev@samza.apache.org Subject: Re: [VOTE] SEP-12: Integration Test Framework +1 On Thu, May 17, 2018 at 9:56 AM, Jagadish Venkatraman < jagadish1...@gmail.com> wrote:

Re: [VOTE] SEP-12: Integration Test Framework

2018-05-17 Thread santhosh venkat
+1. Thanks. On Thu, May 17, 2018 at 10:13 AM, Jacob Maes wrote: > +1 > > On Thu, May 17, 2018 at 9:56 AM, Jagadish Venkatraman < > jagadish1...@gmail.com> wrote: > > > Thanks Sanil for the proposal. This will go a long way in simplifying > > testing of Samza applications. > > > > +1 (binding) >

Re: [VOTE] SEP-12: Integration Test Framework

2018-05-17 Thread Fred Haifeng Ji
+1 On Thu, May 17, 2018 at 11:54 AM, santhosh venkat < santhoshvenkat1...@gmail.com> wrote: > +1. > > Thanks. > > On Thu, May 17, 2018 at 10:13 AM, Jacob Maes wrote: > > > +1 > > > > On Thu, May 17, 2018 at 9:56 AM, Jagadish Venkatraman < > > jagadish1...@gmail.com> wrote: > > > > > Thanks Sanil

Re: [VOTE] Apache Samza 0.14.1 RC1

2018-05-17 Thread Xinyu Liu
Extend the vote to Friday, May 18 5pm. Please take a chance to run the tests and vote for it. Thanks, Xinyu On Wed, May 16, 2018 at 10:44 AM, Xinyu Liu wrote: > A reminder to download the build and vote for it. Since we are passing the > end date for the vote, let's extend to tomorrow 12pm. > >

Re: [VOTE] SEP-12: Integration Test Framework

2018-05-17 Thread Yi Pan
Hi, Sanil, Thanks for the proposal! Overall, looks good to me. Here a few minor comments: - Event Builder Stream (p2): why do we need this instead of injecting events along w/ messages/timer function in CollectionStream? - Closable Task: if there is a per-task system resource opened, close() sho

[GitHub] samza pull request #526: Schedule ZkBarrierChangeHandler into debounce threa...

2018-05-17 Thread shanthoosh
GitHub user shanthoosh opened a pull request: https://github.com/apache/samza/pull/526 Schedule ZkBarrierChangeHandler into debounce thread for execution. In existing implementation, `ZkBarrierChangeHandler` is executed from the `ZkEventThread` and has following drawbacks: * `Z

[GitHub] samza pull request #527: SAMZA-1720: Remove javafx.util dependency from samz...

2018-05-17 Thread shanthoosh
GitHub user shanthoosh opened a pull request: https://github.com/apache/samza/pull/527 SAMZA-1720: Remove javafx.util dependency from samza-sql tests. In samza-sql module, currently few test classes(`TestSamzaSqlRelMessageSerde` and `TestSamzaSqlRelRecordSerde`) are dependent upon