Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-11 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/#review155733 --- Fix it, then Ship it! After addressing the nit. Thanks! docs/

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-11 Thread Jake Maes
> On Nov. 9, 2016, 11:18 p.m., Prateek Maheshwari wrote: > > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java, line 55 > > > > > > What's the execution unit here? The samza-rest server? The monitor?

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

2016-11-11 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review155740 --- docs/learn/documentation/versioned/hdfs/consumer.md (line 22)

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-11 Thread Fred Ji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/#review155753 --- Ship it! Ship It! - Fred Ji On Nov. 11, 2016, 12:22 a.m., Sh