Re: Review Request 53453: Add optional interface for SystemConsumer checkpontListener() for checkpoint notifications

> On Nov. 8, 2016, 11:52 p.m., Prateek Maheshwari wrote: > > samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala, > > line 239 > > > > > > Are you missing a foreach here? > > > > I thi

Re: Review Request 53453: Add optional interface for SystemConsumer checkpontListener() for checkpoint notifications

> On Nov. 9, 2016, 8:48 p.m., Navina Ramesh wrote: > > Is there any practical implementation of this interface . eg. adding to > > kafkasystemconsumer? Or is it expected in the future? I have used it with LiKafka for manual testing, but nothing to check in.. - Boris

Re: Review Request 53453: Add optional interface for SystemConsumer checkpontListener() for checkpoint notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53453/ --- (Updated Nov. 10, 2016, 6:54 p.m.) Review request for samza. Bugs: SAMZA-1042

Re: Review Request 53297: Initial version of adding metrics into samza rest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/#review155625 --- Looks pretty good to me. Some final minor comments and questions.

Re: Review Request 53453: Add optional interface for SystemConsumer checkpontListener() for checkpoint notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53453/ --- (Updated Nov. 10, 2016, 6:58 p.m.) Review request for samza. Bugs: SAMZA-1042

Re: SAMZA-469 - scala 2.11 / move to java?

Hi Thunder, Sorry about the late response. I was refreshing my memory of SAMZA-469 :) Is there something preventing this from getting into a release? > Seems to me like the main roadblock on upgrading to scala 2.11 was related to JDK6. We have already moved away from JDK6 and JDK7. So, I don't see

Re: Review Request 53297: Initial version of adding metrics into samza rest.

> On Nov. 10, 2016, 6:57 p.m., Prateek Maheshwari wrote: > > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java, line 27 > > > > > > Unused import. Removed. > On Nov. 10, 2016, 6:57 p.m., Prateek M

Re: Review Request 53297: Initial version of adding metrics into samza rest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/ --- (Updated Nov. 11, 2016, 12:22 a.m.) Review request for samza and Jake Maes. R

Re: Review Request 53297: Initial version of adding metrics into samza rest.

> On Nov. 5, 2016, 6:47 p.m., Jake Maes wrote: > > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java, line > > 75 > > > > > > I don't think the MetricsConfig constructure takes a subset. > >

Re: Review Request 53297: Initial version of adding metrics into samza rest.

> On Nov. 10, 2016, 10:57 a.m., Prateek Maheshwari wrote: > > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java, line > > 103 > > > > > > Don't understand this interface. What's a SchedulingProvid

Re: Review Request 53297: Initial version of adding metrics into samza rest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/#review155689 --- Ship it! Ship It! - Prateek Maheshwari On Nov. 10, 2016, 4:2