Re: Review Request 53163: SAMZA-901: SamzaAppState re-design for thread safety

2016-10-31 Thread Jagadish Venkatraman
> On Oct. 26, 2016, 2:05 a.m., Jagadish Venkatraman wrote: > > samza-core/src/main/java/org/apache/samza/clustermanager/SamzaApplicationState.java, > > line 56 > > > > > > Prefer `volatile` here. > > > > The

Review Request 53297: Initial version of adding metrics into samza rest.

2016-10-31 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/ --- Review request for samza. Repository: samza Description --- This patch a

Review Request 53326: SAMZA-1045 Move classes from samza-operator/api into samza-api.

2016-10-31 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53326/ --- Review request for samza, Jake Maes, Yi Pan (Data Infrastructure), Prateek Mahes

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-31 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52492/ --- (Updated Oct. 31, 2016, 11:04 p.m.) Review request for samza. Repository: sam

Re: Review Request 53326: SAMZA-1045 Move classes from samza-operator/api into samza-api.

2016-10-31 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53326/ --- (Updated Oct. 31, 2016, 11:27 p.m.) Review request for samza, Jake Maes, Yi Pan

Re: Review Request 53326: SAMZA-1045 Move classes from samza-operator/api into samza-api.

2016-10-31 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53326/#review154337 --- samza-operator/src/main/java/org/apache/samza/operators/api/Messa

Re: Review Request 53326: SAMZA-1045 Move classes from samza-operator/api into samza-api.

2016-10-31 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53326/#review154345 --- Ship it! Discussed offline and we are going to move files first

Re: Review Request 53326: SAMZA-1045 Move classes from samza-operator/api into samza-api.

2016-10-31 Thread Fred Ji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53326/#review154347 --- build.gradle (line 126)

[GitHub] samza pull request #17: SAMZA-1033: Remove import-control from checkstyle

2016-10-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

Re: Producer stopped during leader switch

2016-10-31 Thread Jagadish Venkatraman
Hey David, Apologies for the delayed response. There are a bunch of producer *send* issues that were fixed in samza-11 (SAMZA-1028, SAMZA-1003). With Samza-11, there's improved resiliency and if retries fail, the exception will be propagated to your *StreamTask*, and will end up failing the contai

Re: Review Request 53326: SAMZA-1045 Move classes from samza-operator/api into samza-api.

2016-10-31 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53326/ --- (Updated Nov. 1, 2016, 6:33 a.m.) Review request for samza, Jake Maes, Yi Pan (

Re: Review Request 53326: SAMZA-1045 Move classes from samza-operator/api into samza-api.

2016-10-31 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53326/ --- (Updated Nov. 1, 2016, 6:40 a.m.) Review request for samza, Jake Maes, Yi Pan (

Re: Review Request 53326: SAMZA-1045 Move classes from samza-operator/api into samza-api.

2016-10-31 Thread Jagadish Venkatraman
> On Nov. 1, 2016, 12:13 a.m., Fred Ji wrote: > > build.gradle, line 127 > > > > > > I would recommend keeping the checkstyle on and fixing the > > incompatibility issue so that checkstyle plugin can caputre the sty