Re: Review Request 51142: SAMZA-967: HDFS System Consumer

> On Sept. 13, 2016, 1:37 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/java/org/apache/samza/system/hdfs/partitioner/DirectoryPartitioner.java, > > line 58 > > > > > > nit: since the input whiteL

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

> On Sept. 14, 2016, 6:19 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/java/org/apache/samza/system/hdfs/reader/MultiFileHdfsReader.java, > > line 59 > > > > > > Not sure what are we doing here?

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

> On Sept. 14, 2016, 6:19 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsConfig.scala, > > line 66 > > > > > > It would be nicer to make it conforming to Offs

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

> On Sept. 28, 2016, 12:28 a.m., Navina Ramesh wrote: > > build.gradle, line 308 > > > > > > why is this dependency needed here? It seems like this compile > > dependency is required for samza-hdfs and now samza-hdf

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51142/#review150883 --- samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsConfig

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

> On Sept. 29, 2016, 10:56 a.m., Prateek Maheshwari wrote: > > samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsConfig.scala, > > line 66 > > > > > > "systems.%s.consumer.buffer-capacity" makes sense to me.

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

> On Sept. 28, 2016, 12:28 a.m., Navina Ramesh wrote: > > build.gradle, line 308 > > > > > > why is this dependency needed here? It seems like this compile > > dependency is required for samza-hdfs and now samza-hdf

Review Request 52400: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52400/ --- Review request for samza and Navina Ramesh. Repository: samza Description ---

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

> On Sept. 29, 2016, 5:56 p.m., Prateek Maheshwari wrote: > > samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsConfig.scala, > > line 66 > > > > > > "systems.%s.consumer.buffer-capacity" makes sense to me.

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

> On Sept. 13, 2016, 12:33 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/java/org/apache/samza/system/hdfs/HdfsSystemConsumer.java, > > line 142 > > > > > > Isn't it clearer to have one loop like

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

> On Sept. 29, 2016, 5:56 p.m., Prateek Maheshwari wrote: > > samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsConfig.scala, > > line 66 > > > > > > "systems.%s.consumer.buffer-capacity" makes sense to me.

Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52401/ --- Review request for samza and Navina Ramesh. Repository: samza Description ---

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

> On Sept. 14, 2016, 6:19 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsSystemFactory.scala, > > line 38 > > > > > > Not related to your RB, but could you op

Re: Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52401/ --- (Updated Sept. 29, 2016, 6:26 p.m.) Review request for samza and Navina Ramesh.

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

> On Sept. 14, 2016, 6:19 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsSystemFactory.scala, > > line 38 > > > > > > Not related to your RB, but could you op

Review Request 52402: SAMZA-1020: Remove some deprecated interfaces from 0.10 version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52402/ --- Review request for samza. Repository: samza Description --- Remove the d

Re: Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52401/ --- (Updated Sept. 29, 2016, 6:31 p.m.) Review request for samza and Navina Ramesh.

Re: Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52401/ --- (Updated Sept. 29, 2016, 6:32 p.m.) Review request for samza and Navina Ramesh.

Re: Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52401/#review150896 --- Ship it! Ship It! - Jagadish Venkatraman On Sept. 29, 2016,

Re: Review Request 52402: SAMZA-1020: Remove some deprecated interfaces from 0.10 version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52402/#review150897 --- Ship it! Ship It! - Jagadish Venkatraman On Sept. 29, 2016,

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51142/#review150895 --- Still in the middle (MultiFileHdfsReader). Will continue after lun

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

> On Sept. 14, 2016, 6:19 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/java/org/apache/samza/system/hdfs/reader/MultiFileHdfsReader.java, > > line 59 > > > > > > Not sure what are we doing here?

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52403/#review150907 --- You're not using an atomic compare and set (CAS), so you don't nee

Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52403/ --- Review request for samza. Repository: samza Description --- Current the

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52403/#review150909 --- samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSys

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52403/ --- (Updated Sept. 29, 2016, 9 p.m.) Review request for samza, Navina Ramesh and Ja

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

> On Sept. 29, 2016, 7:08 p.m., Chris Pettitt wrote: > > You're not using an atomic compare and set (CAS), so you don't need an > > atomic ref - a volatile would be sufficient. However, if the code can be > > run in a multi-threaded path, you would indeed want to use CAS to dequeue > > the exc

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

> On Sept. 29, 2016, 7:33 p.m., Prateek Maheshwari wrote: > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala, > > line 65 > > > > > > maybe firstCallbackException? > > Don't th

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

> On Sept. 29, 2016, 12:33 p.m., Prateek Maheshwari wrote: > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala, > > line 202 > > > > > > Wondering why we rethrow a previously saved

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52403/ --- (Updated Sept. 29, 2016, 9:23 p.m.) Review request for samza, Navina Ramesh and

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52403/#review150947 --- samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSys

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52403/#review150948 --- Ship it! lgtm. Thanks! samza-kafka/src/main/scala/org/apache/

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

> On Sept. 29, 2016, 9:31 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala, > > line 59 > > > > > > nit: be consistent w/ the code: exce

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52403/#review150951 --- samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSys

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51142/#review150949 --- Fix it, then Ship it! Overall looks pretty good to me. Just a f

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51142/#review150953 --- samza-shell/src/main/bash/run-job-for-azkaban.sh (line 1)

[GitHub] samza pull request #16: SAMZA-1030 : Add documentation for change in the con...

GitHub user navina opened a pull request: https://github.com/apache/samza/pull/16 SAMZA-1030 : Add documentation for change in the contribution process I re-organized some of the website files and created a "Contributor's Corner" that collates all info related to new contributors an

[GitHub] samza pull request #16: SAMZA-1030 : Add documentation for change in the con...

Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable