Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-26 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51703/#review150435 --- docs/learn/documentation/versioned/rest/monitors.md (line 28)

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-26 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51703/ --- (Updated Sept. 26, 2016, 9:13 p.m.) Review request for samza, Boris Shkolnik, J

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-26 Thread Shanthoosh Venkataraman
> On Sept. 26, 2016, 7:37 p.m., Jake Maes wrote: > > samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java, > > lines 81-84 > > > > > > If I'm reading this correctly, this test depends on MapConfi

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-26 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51703/#review150462 --- Almost there. 2 more comments. Also, remember to attach the patch

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-26 Thread Jake Maes
> On Sept. 26, 2016, 9:46 p.m., Jake Maes wrote: > > docs/learn/documentation/versioned/rest/monitors.md, lines 43-50 > > > > > > These properties replace monitor.classes and monitor.run.interval.ms, > > right? > >

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-26 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51703/ --- (Updated Sept. 26, 2016, 11:14 p.m.) Review request for samza, Boris Shkolnik,

Re: Review Request 52140: added docs for split deployment

2016-09-26 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52140/ --- (Updated Sept. 27, 2016, 12:58 a.m.) Review request for samza. Changes --

Re: Review Request 52140: added docs for split deployment

2016-09-26 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52140/#review150500 --- Ship it! Ship It! - Xinyu Liu On Sept. 27, 2016, 12:58 a.m.,