[REPORT] Samza - July 2016

2016-07-12 Thread Chris Riccomini
## Description: - Apache Samza is a stream processing framework built on top of Apache Hadoop YARN and Apache Kafka. ## Issues: There are no issues requiring board attention at this time. ## Activity: - Good coverage of Apache Samza at Hadoop summit. Several talks about it. - Meetup at L

Re: Review Request 49877: SAMZA-972: Holistic memory monitoring for SamzaContainer

2016-07-12 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49877/#review141915 --- Biggest concern with this patch is that it seems to bake in a depe

Re: Review Request 49877: SAMZA-972: Holistic memory monitoring for SamzaContainer

2016-07-12 Thread Chris Pettitt
> On July 11, 2016, 6:47 p.m., Chris Pettitt wrote: > > Very high level question: I assume you looked at `ps -o rss` and > > disqualified it for some reason. Could you elaborate as to why? `ps` itself > > is certainly more portable than procfs (though `-o rss` is not part of the > > POSIX stan

Re: Review Request 48356: RFC: Samza as a library

2016-07-12 Thread Navina Ramesh
> On July 12, 2016, 12:15 a.m., Fred Ji wrote: > > samza-core/src/main/java/org/apache/samza/config/TaskConfigJava.java, line > > 131 > > > > > > [INFO Question] Just curious, Is there a required code convention for

Re: Review Request 48356: RFC: Samza as a library

2016-07-12 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48356/#review141942 --- Fix it, then Ship it! Noticed one issue while responding to you

Re: Review Request 48356: RFC: Samza as a library

2016-07-12 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48356/ --- (Updated July 12, 2016, 6:45 p.m.) Review request for samza, Chris Pettitt and

Re: Review Request 48356: RFC: Samza as a library

2016-07-12 Thread Chris Pettitt
> On June 27, 2016, 6:53 p.m., Chris Pettitt wrote: > > A few more thoughts below. > > > > Still not a fan of the direction we're going with the config. I know it is > > status quo, but it further locks us into a limited model. One other benefit > > of the Offspring way of doing config that oc

Re: Review Request 48356: RFC: Samza as a library

2016-07-12 Thread Navina Ramesh
> On July 12, 2016, 6:43 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/processor/StreamProcessor.java, > > lines 174-176 > > > > > > Don't we need to synchronize these? Are we guaranteed

Re: Review Request 48356: RFC: Samza as a library

2016-07-12 Thread Chris Pettitt
> On July 12, 2016, 6:43 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/processor/StreamProcessor.java, > > lines 174-176 > > > > > > Don't we need to synchronize these? Are we guaranteed

Re: Review Request 48356: RFC: Samza as a library

2016-07-12 Thread Fred Ji
> On July 12, 2016, 12:15 a.m., Fred Ji wrote: > > samza-core/src/main/java/org/apache/samza/configbuilder/ConfigBuilder.java, > > line 92 > > > > > > Maybe if(!StringUtils.isBlank())? Since we would like to have a v

Re: Review Request 48356: RFC: Samza as a library

2016-07-12 Thread Navina Ramesh
> On July 12, 2016, 12:15 a.m., Fred Ji wrote: > > samza-core/src/main/java/org/apache/samza/configbuilder/SerdeConfig.java, > > line 43 > > > > > > Could serdeAlias be null accidentally? If so, it would be better to

Re: Review Request 48356: RFC: Samza as a library

2016-07-12 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48356/ --- (Updated July 12, 2016, 10:02 p.m.) Review request for samza, Chris Pettitt and

Re: Review Request 48356: RFC: Samza as a library

2016-07-12 Thread Navina Ramesh
> On July 12, 2016, 12:15 a.m., Fred Ji wrote: > > samza-core/src/main/java/org/apache/samza/configbuilder/ConfigBuilder.java, > > line 92 > > > > > > Maybe if(!StringUtils.isBlank())? Since we would like to have a v

Re: Review Request 48356: RFC: Samza as a library

2016-07-12 Thread Fred Ji
> On July 12, 2016, 12:15 a.m., Fred Ji wrote: > > samza-core/src/main/java/org/apache/samza/configbuilder/ConfigBuilder.java, > > line 92 > > > > > > Maybe if(!StringUtils.isBlank())? Since we would like to have a v

Re: Review Request 48356: RFC: Samza as a library

2016-07-12 Thread Fred Ji
> On July 12, 2016, 12:15 a.m., Fred Ji wrote: > > samza-core/src/main/java/org/apache/samza/configbuilder/ConfigBuilder.java, > > line 92 > > > > > > Maybe if(!StringUtils.isBlank())? Since we would like to have a v

Re: Review Request 48356: RFC: Samza as a library

2016-07-12 Thread Navina Ramesh
> On July 12, 2016, 12:15 a.m., Fred Ji wrote: > > samza-core/src/main/java/org/apache/samza/configbuilder/ConfigBuilder.java, > > line 92 > > > > > > Maybe if(!StringUtils.isBlank())? Since we would like to have a v

Re: Review Request 49877: SAMZA-972: Holistic memory monitoring for SamzaContainer

2016-07-12 Thread Fred Ji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49877/#review141989 --- Thanks for the RB. I have a few comments for clarification. samz

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

2016-07-12 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48243/ --- (Updated July 13, 2016, 12:51 a.m.) Review request for samza, Chris Pettitt, Na