Re: Review Request 44920: SAMZA-680 Refactor the Samza AppMaster to support other cluster managers

2016-04-06 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44920/ --- (Updated April 6, 2016, 5:31 p.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 44920: SAMZA-680 Refactor the Samza AppMaster to support other cluster managers

2016-04-06 Thread Jagadish Venkatraman
> On April 5, 2016, 9:55 p.m., Navina Ramesh wrote: > > samza-shell/src/main/bash/run-am.sh, line 28 > > > > > > It's kind of confusing when you set samza.container.name to be > > "samza-application-master" and then,

Re: Review Request 44920: SAMZA-680 Refactor the Samza AppMaster to support other cluster managers

2016-04-06 Thread Navina Ramesh
> On April 5, 2016, 9:55 p.m., Navina Ramesh wrote: > > samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java, > > line 109 > > > > > > Why not move this class loader helper method in