Re: Review Request 50451: SAMZA-981: Set consistent Kafka clientId for a job instance

2016-07-28 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50451/#review144018 --- Ship it! +1. I would recommend to add the reason for this chang

Re: Review Request 50451: SAMZA-981: Set consistent Kafka clientId for a job instance

2016-07-26 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50451/ --- (Updated July 26, 2016, 11:46 p.m.) Review request for samza, Navina Ramesh and

Re: Review Request 50451: SAMZA-981: Set consistent Kafka clientId for a job instance

2016-07-26 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50451/ --- (Updated July 26, 2016, 11:44 p.m.) Review request for samza, Navina Ramesh and

Re: Review Request 50451: SAMZA-981: Set consistent Kafka clientId for a job instance

2016-07-26 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50451/#review143591 --- Fix it, then Ship it! lgtm! samza-kafka/src/test/scala/org/ap

Re: Review Request 50451: SAMZA-981: Set consistent Kafka clientId for a job instance

2016-07-26 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50451/ --- (Updated July 26, 2016, 6:15 p.m.) Review request for samza, Navina Ramesh and

Review Request 50451: SAMZA-981: Set consistent Kafka clientId for a job instance

2016-07-26 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50451/ --- Review request for samza, Navina Ramesh and Yi Pan (Data Infrastructure). Repos