Re: Review Request 48352: Added java friendly api to KafkaMetrics

2016-06-07 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48352/#review136564 --- Ship it! I am assuming we won't run into problems where a metri

Re: Review Request 48352: Added java friendly api to KafkaMetrics

2016-06-07 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48352/ --- (Updated June 7, 2016, 11:59 p.m.) Review request for samza and Navina Ramesh.

Re: Review Request 48352: Added java friendly api to KafkaMetrics

2016-06-07 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48352/#review136518 --- Fix it, then Ship it! +1 ! samza-kafka/src/main/scala/org/apa

Review Request 48352: Added java friendly api to KafkaMetrics

2016-06-07 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48352/ --- Review request for samza and Navina Ramesh. Bugs: SAMZA-962 https://issues.