Re: Review Request 44405: SAMZA-882 - Detect partition count changes in input streams

2016-03-23 Thread Navina Ramesh
> On March 23, 2016, 7:53 p.m., Jake Maes wrote: > > Why was the (new) monitor written in Scala? > > > > Also, one issue below. I started writing in Java and ended up with some issue where I had to construct scala Map / Sets and it just became harder. It was much simpler to use scala. > On M

Re: Review Request 44405: SAMZA-882 - Detect partition count changes in input streams

2016-03-23 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44405/#review125108 --- Why was the (new) monitor written in Scala? Also, one issue below

Re: Review Request 44405: SAMZA-882 - Detect partition count changes in input streams

2016-03-22 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44405/#review124917 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On March 19

Re: Review Request 44405: SAMZA-882 - Detect partition count changes in input streams

2016-03-19 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44405/#review124223 --- samza-core/src/main/scala/org/apache/samza/coordinator/StreamPart

Re: Review Request 44405: SAMZA-882 - Detect partition count changes in input streams

2016-03-18 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44405/ --- (Updated March 19, 2016, 2:30 a.m.) Review request for samza, Boris Shkolnik, J

Re: Review Request 44405: SAMZA-882 - Detect partition count changes in input streams

2016-03-18 Thread Navina Ramesh
> On March 18, 2016, 5:07 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/scala/org/apache/samza/coordinator/StreamPartitionCountMonitor.scala, > > line 77 > > > > > > Can we make sure that either a

Re: Review Request 44405: SAMZA-882 - Detect partition count changes in input streams

2016-03-15 Thread Navina Ramesh
> On March 14, 2016, 11:46 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/scala/org/apache/samza/system/StreamMetadataCache.scala, > > line 101 > > > > > > I am a bit confused here. I thought that

Re: Review Request 44405: SAMZA-882 - Detect partition count changes in input streams

2016-03-15 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44405/ --- (Updated March 16, 2016, 4:09 a.m.) Review request for samza, Boris Shkolnik, J

Re: Review Request 44405: SAMZA-882 - Detect partition count changes in input streams

2016-03-15 Thread Navina Ramesh
> On March 14, 2016, 11:46 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/scala/org/apache/samza/coordinator/StreamPartitionCountMonitor.scala, > > line 78 > > > > > > Won't this be redundant w/ th

Re: Review Request 44405: SAMZA-882 - Detect partition count changes in input streams

2016-03-14 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44405/#review123527 --- samza-core/src/main/scala/org/apache/samza/coordinator/StreamPart

Review Request 44405: SAMZA-882 - Detect partition count changes in input streams

2016-03-04 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44405/ --- Review request for samza, Boris Shkolnik, Jake Maes, Jagadish Venkatraman, Xinyu