Re: Review Request 43732: Implemented AvroDataFileHdfsWriter

2016-03-03 Thread Edi Bice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43732/ --- (Updated March 3, 2016, 6:58 p.m.) Review request for samza. Changes ---

Re: Review Request 43732: Implemented AvroDataFileHdfsWriter

2016-03-02 Thread Edi Bice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43732/ --- (Updated March 2, 2016, 4:35 p.m.) Review request for samza. Changes ---

Re: Review Request 43732: Implemented AvroDataFileHdfsWriter

2016-03-01 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43732/#review121594 --- Overall lgtm. There is some problem in the last file in the diff u

Re: Review Request 43732: Implemented AvroDataFileHdfsWriter

2016-02-25 Thread Edi Bice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43732/ --- (Updated Feb. 25, 2016, 7:39 p.m.) Review request for samza. Changes ---

Re: Review Request 43732: Implemented AvroDataFileHdfsWriter and exposed several RocksDb config

2016-02-25 Thread Edi Bice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43732/ --- (Updated Feb. 25, 2016, 4:50 p.m.) Review request for samza. Changes ---

Re: Review Request 43732: Implemented AvroDataFileHdfsWriter and exposed several RocksDb config

2016-02-25 Thread Edi Bice
> On Feb. 23, 2016, 6:51 p.m., Yi Pan (Data Infrastructure) wrote: > > Thanks for the contribution! I added a few comments below. Thanks You're welcome. Thanks for Samza. > On Feb. 23, 2016, 6:51 p.m., Yi Pan (Data Infrastructure) wrote: > > gradle.properties, line 18 > >

Re: Review Request 43732: Implemented AvroDataFileHdfsWriter and exposed several RocksDb config

2016-02-23 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43732/#review120357 --- Thanks for the contribution! I added a few comments below. Thanks

Review Request 43732: Implemented AvroDataFileHdfsWriter and exposed several RocksDb config

2016-02-18 Thread Edi Bice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43732/ --- Review request for samza. Repository: samza Description --- https://issu