Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

2016-04-14 Thread Tao Feng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41106/ --- (Updated April 15, 2016, 3:55 a.m.) Review request for samza. Repository: sam

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

2015-12-09 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41106/#review109687 --- Ship it! Ship It! - Jake Maes On Dec. 10, 2015, 4:34 a.m., Tao

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

2015-12-09 Thread Tao Feng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41106/ --- (Updated Dec. 10, 2015, 4:34 a.m.) Review request for samza. Repository: samz

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

2015-12-09 Thread Tao Feng
> On Dec. 9, 2015, 6:06 p.m., Jake Maes wrote: > > samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala, > > line 38 > > > > > > nit: this message will no longer be valid after we fully deprec

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

2015-12-09 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41106/#review109619 --- Ship it! - Boris Shkolnik On Dec. 9, 2015, 6:41 a.m., Tao Feng w

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

2015-12-09 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41106/#review109571 --- Ship it! samza-core/src/main/scala/org/apache/samza/job/local/Pro

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

2015-12-08 Thread Tao Feng
> On Dec. 8, 2015, 11:20 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala, > > line 54 > > > > > > It would be better to use JobConfig.getCont

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

2015-12-08 Thread Tao Feng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41106/ --- (Updated Dec. 9, 2015, 6:41 a.m.) Review request for samza. Repository: samza

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

2015-12-08 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41106/#review109428 --- Thanks, Tao! One issue in the comment. samza-core/src/main/scala/

Review Request 41106: SAMZA-833: ProcessJob mishandling containers

2015-12-08 Thread Tao Feng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41106/ --- Review request for samza. Repository: samza Description --- throws runti