Re: Review Request 41068: SAMZA-813: Add Seek functionality to KeyValueStoreIterator

2016-03-08 Thread Amit Yadav
> On March 7, 2016, 8:42 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-api/src/main/java/org/apache/samza/storage/kv/KeyValueIterator.java, > > line 27 > > > > > > I recommend to drop this seekToLast() for now.

Re: Review Request 41068: SAMZA-813: Add Seek functionality to KeyValueStoreIterator

2016-03-08 Thread Amit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41068/ --- (Updated March 9, 2016, 12:26 a.m.) Review request for samza and Yi Pan (Data I

Re: Review Request 41068: SAMZA-813: Add Seek functionality to KeyValueStoreIterator

2016-03-07 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41068/#review122271 --- @Amit, the patch lgtm overall. I have a comment on seekToLast(). I

Re: Review Request 41068: SAMZA-813: Add Seek functionality to KeyValueStoreIterator

2016-02-26 Thread Amit Yadav
> On Dec. 8, 2015, 10:55 p.m., Yi Pan (Data Infrastructure) wrote: > > @Amit, thanks for putting up this patch. I have two high-level comments: > > * I would prefer to keep the return type of seek() as an iterator. The > > pattern of the current API looks fine to me: all() and range() gives > >

Re: Review Request 41068: SAMZA-813: Add Seek functionality to KeyValueStoreIterator

2016-02-26 Thread Amit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41068/ --- (Updated Feb. 26, 2016, 6:37 p.m.) Review request for samza and Yi Pan (Data In

Re: Review Request 41068: SAMZA-813: Add Seek functionality to KeyValueStoreIterator

2016-01-19 Thread Yi Pan (Data Infrastructure)
> On Dec. 8, 2015, 10:55 p.m., Yi Pan (Data Infrastructure) wrote: > > @Amit, thanks for putting up this patch. I have two high-level comments: > > * I would prefer to keep the return type of seek() as an iterator. The > > pattern of the current API looks fine to me: all() and range() gives > >

Re: Review Request 41068: SAMZA-813: Add Seek functionality to KeyValueStoreIterator

2015-12-08 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41068/#review109417 --- @Amit, thanks for putting up this patch. I have two high-level comm

Review Request 41068: SAMZA-813: Add Seek functionality to KeyValueStoreIterator

2015-12-07 Thread Amit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41068/ --- Review request for samza. Repository: samza Description --- Added Seek f