Re: Review Request 40624: SAMZA-775: netflix patch for memory size based throttling.

2015-11-24 Thread Yi Pan (Data Infrastructure)
> On Nov. 24, 2015, 8:07 p.m., Navina Ramesh wrote: > > samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java, > > line 37 > > > > > > Prefer annotation here saying @VisibleForTesting > >

Re: Review Request 40624: SAMZA-775: netflix patch for memory size based throttling.

2015-11-24 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40624/#review107868 --- Ship it! Ship It! - Navina Ramesh On Nov. 24, 2015, 11:11 p.m.,

Re: Review Request 40624: SAMZA-775: netflix patch for memory size based throttling.

2015-11-24 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40624/ --- (Updated Nov. 24, 2015, 11:11 p.m.) Review request for samza, Monal Daxini and

Re: Review Request 40624: SAMZA-775: netflix patch for memory size based throttling.

2015-11-24 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40624/#review107823 --- Ship it! Overall, looks good. Some minor nits and question. Clarif

Re: Review Request 40624: SAMZA-775: netflix patch for memory size based throttling.

2015-11-24 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40624/ --- (Updated Nov. 24, 2015, 8 p.m.) Review request for samza, Monal Daxini and Navi

Review Request 40624: SAMZA-775: netflix patch for memory size based throttling.

2015-11-23 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40624/ --- Review request for samza, Monal Daxini and Navina Ramesh. Bugs: SAMZA-775 h