Re: Review Request 40313: SAMZA-785

2016-09-19 Thread VENKATA KRISHNA NANNAPANENI
> On Nov. 16, 2015, 7:34 p.m., Boris Shkolnik wrote: > > > > VENKATA KRISHNA NANNAPANENI wrote: > Is there anything I need to do like commit or create pull request? I > wasn't aware of the process from here. > > Navina Ramesh wrote: > Sorry for the delay, Venkata Krishna Nannapaneni. W

Re: Review Request 40313: SAMZA-785

2016-01-04 Thread VENKATA KRISHNA NANNAPANENI
> On Nov. 18, 2015, 9:31 p.m., Navina Ramesh wrote: > > samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java, > > line 242 > > > > > > What happens if serdeName is not defined at stream or sy

Re: Review Request 40313: SAMZA-785

2016-01-04 Thread VENKATA KRISHNA NANNAPANENI
> On Nov. 18, 2015, 9:31 p.m., Navina Ramesh wrote: > > Sorry, I hope this is not too late. It does throw an exception if it can't find the serde. - VENKATA KRISHNA --- This is an automatically generated e-mail. To reply, visit: https:

Re: Review Request 40313: SAMZA-785

2015-11-18 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40313/#review107091 --- samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamApp

Re: Review Request 40313: SAMZA-785

2015-11-18 Thread Navina Ramesh
> On Nov. 16, 2015, 7:34 p.m., Boris Shkolnik wrote: > > > > VENKATA KRISHNA NANNAPANENI wrote: > Is there anything I need to do like commit or create pull request? I > wasn't aware of the process from here. Sorry for the delay, Venkata Krishna Nannapaneni. We are currently closing up the

Re: Review Request 40313: SAMZA-785

2015-11-18 Thread VENKATA KRISHNA NANNAPANENI
> On Nov. 16, 2015, 7:34 p.m., Boris Shkolnik wrote: > > Is there anything I need to do like commit or create pull request? I wasn't aware of the process from here. - VENKATA KRISHNA --- This is an automatically generated e-mail. To re

Re: Review Request 40313: SAMZA-785

2015-11-16 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40313/#review106697 --- Ship it! - Boris Shkolnik On Nov. 13, 2015, 10:51 p.m., VENKATA

Review Request 40313: SAMZA-785

2015-11-13 Thread VENKATA KRISHNA NANNAPANENI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40313/ --- Review request for samza. Repository: samza Description --- check for sy