Re: Review Request 38614: SAMZA-615: Add auto-checkpoint migration for Kafka checkpoints

2015-09-23 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38614/#review100355 --- Ship it! lgtm! Let's get this checked-in :) samza-core/src/test/

Re: Review Request 38614: SAMZA-615: Add auto-checkpoint migration for Kafka checkpoints

2015-09-23 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38614/#review100177 --- Ship it! I am not completely happy with the "old.checkpoint" packa

Re: Review Request 38614: SAMZA-615: Add auto-checkpoint migration for Kafka checkpoints

2015-09-22 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38614/#review99969 --- Ship it! Looks good to me. I hope you were able to test with a samp

Re: Review Request 38614: SAMZA-615: Add auto-checkpoint migration for Kafka checkpoints

2015-09-22 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38614/ --- (Updated Sept. 22, 2015, 11 p.m.) Review request for samza, Yan Fang and Navina

Re: Review Request 38614: SAMZA-615: Add auto-checkpoint migration for Kafka checkpoints

2015-09-22 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38614/ --- (Updated Sept. 22, 2015, 6:53 p.m.) Review request for samza, Yan Fang and Navi

Re: Review Request 38614: SAMZA-615: Add auto-checkpoint migration for Kafka checkpoints

2015-09-22 Thread Yi Pan (Data Infrastructure)
> On Sept. 22, 2015, 10 a.m., Navina Ramesh wrote: > > samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/CoordinatorStreamMessage.java, > > line 295 > > > > > > I separated out this change for SA

Re: Review Request 38614: SAMZA-615: Add auto-checkpoint migration for Kafka checkpoints

2015-09-22 Thread Yi Pan (Data Infrastructure)
> On Sept. 22, 2015, 10 a.m., Navina Ramesh wrote: > > samza-core/src/test/java/org/apache/samza/coordinator/stream/MockCoordinatorStreamSystemFactory.java, > > line 26 > > > > > > Can you please import only the nece

Re: Review Request 38614: SAMZA-615: Add auto-checkpoint migration for Kafka checkpoints

2015-09-22 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38614/#review99963 --- samza-core/src/main/java/org/apache/samza/coordinator/stream/messag

Review Request 38614: SAMZA-615: Add auto-checkpoint migration for Kafka checkpoints

2015-09-22 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38614/ --- Review request for samza, Yan Fang and Navina Ramesh. Bugs: SAMZA-615 https