Re: Review Request 37506: WIP: SAMZA-552 Operator API change: New Builder API

2015-09-03 Thread Milinda Pathirage
> On Aug. 24, 2015, 8:35 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-sql-core/src/test/java/org/apache/samza/task/sql/StreamSqlTask.java, > > line 89 > > > > > > The goal here is to use the topology builder t

Re: Review Request 37506: WIP: SAMZA-552 Operator API change: New Builder API

2015-09-03 Thread Milinda Pathirage
> On Aug. 24, 2015, 8:35 a.m., Yi Pan (Data Infrastructure) wrote: > > Hi, Milinda, sorry for the late review. I have put down my comments below. > > Overall, there are two things to be discussed: > > 1) Adding OperatorBuilder interface as well. It serves two purposes: > >a) I remember that

Re: Review Request 37506: WIP: SAMZA-552 Operator API change: New Builder API

2015-08-24 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37506/#review96136 --- Hi, Milinda, sorry for the late review. I have put down my comments

Re: Review Request 37506: WIP: SAMZA-552 Operator API change: New Builder API

2015-08-16 Thread Milinda Pathirage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37506/ --- (Updated Aug. 16, 2015, 3:57 p.m.) Review request for samza, Yi Pan (Data Infra

Re: Review Request 37506: WIP: SAMZA-552 Operator API change: New Builder API

2015-08-16 Thread Milinda Pathirage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37506/ --- (Updated Aug. 16, 2015, 3:56 p.m.) Review request for samza, Yi Pan (Data Infra

Review Request 37506: WIP: SAMZA-552 Operator API change: New Builder API

2015-08-16 Thread Milinda Pathirage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37506/ --- Review request for samza, Yi Pan (Data Infrastructure) and Navina Ramesh. Bugs: