Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36473/ --- (Updated July 22, 2015, 5 p.m.) Review request for samza. Repository: samza

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

> On July 21, 2015, 5:42 p.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/metrics/MetricsHelper.scala, > > lines 36-37 > > > > > > though it works, prefer to use the "def" here, not only because i

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36473/ --- (Updated July 22, 2015, 4:07 a.m.) Review request for samza. Repository: samz

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

> On July 21, 2015, 5:42 p.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/metrics/MetricsHelper.scala, > > lines 36-37 > > > > > > though it works, prefer to use the "def" here, not only because i

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

> On July 21, 2015, 5:42 p.m., Yan Fang wrote: > > samza-core/src/main/java/org/apache/samza/metrics/MetricsBase.java, line 23 > > > > > > of the class "the" extends -> of the class "that" extends Thanks > On July

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36473/#review92429 --- samza-core/src/main/java/org/apache/samza/metrics/MetricsBase.java

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36473/ --- (Updated July 21, 2015, 5:41 a.m.) Review request for samza. Changes ---

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36473/ --- (Updated July 15, 2015, 4:45 a.m.) Review request for samza. Changes ---

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

> On 七月 14, 2015, 9:44 p.m., Yan Fang wrote: > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetrics.java, > > line 24 > > > > > > can this class extends Metrics

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

> On July 14, 2015, 9:44 p.m., Yan Fang wrote: > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetrics.java, > > line 24 > > > > > > can this class extends Metri

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

> On July 14, 2015, 9:44 p.m., Yan Fang wrote: > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetrics.java, > > line 24 > > > > > > can this class extends Metri

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

> On July 14, 2015, 9:44 p.m., Yan Fang wrote: > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, > > line 152 > > > > > > remove the space Sure thing. -

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

> On July 14, 2015, 9:44 p.m., Yan Fang wrote: > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetrics.java, > > line 24 > > > > > > can this class extends Metri

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36473/#review91670 --- samza-elasticsearch/src/main/java/org/apache/samza/system/elasticse

Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36473/ --- Review request for samza. Repository: samza Description --- SAMZA-733 Ad