Re: Review Request 35397: Fix SAMZA-697

> On July 7, 2015, 12:42 a.m., Boris Shkolnik wrote: > > The latest diff seems incomplete. Missing some file(s). Ahh yes. Added the missing files. - Guozhang --- This is an automatically generated e-mail. To reply, visit: https://review

Re: Review Request 35397: Fix SAMZA-697

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35397/ --- (Updated July 10, 2015, 4:54 p.m.) Review request for samza. Summary (updated

Re: Review Request 35397: Fix Samza-697

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35397/#review90620 --- The latest diff seems incomplete. Missing some file(s). - Boris Shk

Re: Review Request 35397: Fix Samza-697

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35397/ --- (Updated June 30, 2015, 6:29 p.m.) Review request for samza. Summary (updated

Re: Review Request 35397: Fix SAMZA-697

> On June 19, 2015, 8:59 a.m., Yi Pan (Data Infrastructure) wrote: > > docs/learn/documentation/versioned/jobs/configuration-table.html, line 443 > > > > > > Users who extends and implements StreamTask usually have the

Re: Review Request 35397: Fix SAMZA-697

> On June 18, 2015, 11:58 p.m., Boris Shkolnik wrote: > > samza-core/src/main/java/org/apache/samza/task/TaskClassLoader.java, line 50 > > > > > > Do we have test for this case? We check this case in TestTaskClassLoade

Re: Review Request 35397: Fix SAMZA-697

> On June 17, 2015, 9:03 p.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala, > > lines 103-111 > > > > > > a little concernted about this. This means we will load the cla

Re: Review Request 35397: Fix SAMZA-697

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35397/#review88236 --- Overall looks good. I have a few comments/questions. Thanks! bin/c

Re: Review Request 35397: Fix SAMZA-697

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35397/#review88455 --- This is partial review (I didn't go thru the test). samza-core/src

Re: Review Request 35397: Fix SAMZA-697

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35397/ --- (Updated June 18, 2015, 6:42 p.m.) Review request for samza. Bugs: SAMZA-697

Re: Review Request 35397: Fix SAMZA-697

> On June 17, 2015, 9:03 p.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala, > > lines 103-111 > > > > > > a little concernted about this. This means we will load the cla

Re: Review Request 35397: Fix SAMZA-697

> On June 17, 2015, 9:03 p.m., Yan Fang wrote: > > samza-core/src/main/java/org/apache/samza/task/TaskClassLoader.java, line 75 > > > > > > use "if" to be consistent? I thought there may be some class paths that contai

Re: Review Request 35397: Fix SAMZA-697

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35397/#review88260 --- samza-core/src/main/java/org/apache/samza/task/TaskClassLoader.java

Re: Review Request 35397: Fix SAMZA-697

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35397/ --- (Updated June 16, 2015, 5:22 p.m.) Review request for samza. Bugs: SAMZA-697

Re: Review Request 35397: Fix SAMZA-697

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35397/ --- (Updated June 12, 2015, 5:57 p.m.) Review request for samza. Bugs: SAMZA-697

Review Request 35397: Fix SAMZA-697

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35397/ --- Review request for samza. Repository: samza Description --- Use a separa