Re: Review Request 34974: SAMZA-676: implement broadcast stream

2015-08-20 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34974/#review96013 --- Ship it! I am fine if we are not adding the isBroadcast flag. We ca

Re: Review Request 34974: SAMZA-676: implement broadcast stream

2015-08-20 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34974/ --- (Updated Aug. 20, 2015, 8:13 p.m.) Review request for samza. Changes ---

Re: Review Request 34974: SAMZA-676: implement broadcast stream

2015-08-11 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34974/#review94980 --- Ship it! Ship It! - Navina Ramesh On July 29, 2015, 10:49 p.m.,

Re: Review Request 34974: SAMZA-676: implement broadcast stream

2015-08-11 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34974/#review93553 --- Lgtm, overall! I was able to test it as well. Some feedback: Would i

Re: Review Request 34974: SAMZA-676: implement broadcast stream

2015-07-29 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34974/ --- (Updated July 29, 2015, 10:49 p.m.) Review request for samza. Changes ---

Re: Review Request 34974: SAMZA-676: implement broadcast stream

2015-06-21 Thread Yan Fang
> On June 18, 2015, 10:37 p.m., Navina Ramesh wrote: > > Mostly looks good. Have some questions: > > * Have you tried the message "filtering" logic to the container level > > instead of the task level ? Not sure which is simpler in terms of code > > change. Since the container has access to all

Re: Review Request 34974: SAMZA-676: implement broadcast stream

2015-06-21 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34974/ --- (Updated June 22, 2015, 6:07 a.m.) Review request for samza. Changes ---

Re: Review Request 34974: SAMZA-676: implement broadcast stream

2015-06-18 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34974/#review88308 --- Mostly looks good. Have some questions: * Have you tried the message

Re: Review Request 34974: SAMZA-676: implement broadcast stream

2015-06-16 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34974/ --- (Updated June 16, 2015, 9:23 p.m.) Review request for samza. Changes ---

Re: Review Request 34974: SAMZA-676: implement broadcast stream

2015-06-16 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34974/ --- (Updated June 16, 2015, 9:16 p.m.) Review request for samza. Changes ---

Re: Review Request 34974: SAMZA-676: implement broadcast stream

2015-06-16 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34974/ --- (Updated June 16, 2015, 9:06 p.m.) Review request for samza. Changes ---

Review Request 34974: SAMZA-676: implement broadcast stream

2015-06-02 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34974/ --- Review request for samza. Bugs: SAMZA-676 https://issues.apache.org/jira/br