Re: Review Request 34009: SAMZA-552 window store implementation

2015-05-13 Thread Navina Ramesh
> On May 13, 2015, 9:56 p.m., Navina Ramesh wrote: > > samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomWindowOperatorTask.java, > > line 96 > > > > > > Shouldn't the window id be system generated? > > Yi

Re: Review Request 34009: SAMZA-552 window store implementation

2015-05-13 Thread Yi Pan (Data Infrastructure)
> On May 13, 2015, 9:56 p.m., Navina Ramesh wrote: > > samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateTimeWindowOp.java, > > line 309 > > > > > > There are 2 refresh method definitions - o

Re: Review Request 34009: SAMZA-552 window store implementation

2015-05-13 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34009/#review83667 --- samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/

Re: Review Request 34009: SAMZA-552 window store implementation

2015-05-13 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34009/ --- (Updated May 13, 2015, 5:36 p.m.) Review request for samza, Chris Riccomini, Gu