Re: Review Request 33749: WIP: SAMZA-650 window store implementation

> On May 7, 2015, 2:35 p.m., Milinda Pathirage wrote: > > samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateTimeWindowAutoOp.java, > > line 30 > > > > > > Hi Yi, What is automated operator in

Re: Review Request 33749: WIP: SAMZA-650 window store implementation

> On May 7, 2015, 2:22 p.m., Milinda Pathirage wrote: > > samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoiner.java, > > line 47 > > > > > > I think that stream-to-stream joining is not p

Re: Review Request 33749: WIP: SAMZA-650 window store implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33749/#review82824 --- samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/

Re: Review Request 33749: WIP: SAMZA-650 window store implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33749/#review82821 --- samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/St

Re: Review Request 33749: WIP: SAMZA-650 window store implementation

> On May 6, 2015, 2:16 p.m., Milinda Pathirage wrote: > > samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/MessageStore.java, > > line 40 > > > > > > Invalid parameter in doc comment. Thanks! Will fi

Re: Review Request 33749: WIP: SAMZA-650 window store implementation

> On May 6, 2015, 2:11 p.m., Milinda Pathirage wrote: > > samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/FilteredMessageIterator.java, > > line 54 > > > > > > I'm not sure whether this is 100% correct

Re: Review Request 33749: WIP: SAMZA-650 window store implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33749/#review82673 --- samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/Fi

Re: Review Request 33749: WIP: SAMZA-650 window store implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33749/#review82674 --- samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/Me

Re: Review Request 33749: WIP: SAMZA-650 window store implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33749/ --- (Updated May 4, 2015, 6:58 a.m.) Review request for samza, Chris Riccomini, Guo

Review Request 33749: WIP: SAMZA-650 window store implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33749/ --- Review request for samza, Chris Riccomini, Guozhang Wang, Milinda Pathirage, Nav