Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

> On May 26, 2015, 7:40 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/schema/Stream.java, > > line 80 > > > > > > Question: do we have a way to specify the p

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

> On May 26, 2015, 7:40 a.m., Yi Pan (Data Infrastructure) wrote: > > build.gradle, line 408 > > > > > > You might need to re-base this change. > > Milinda Pathirage wrote: > Hi Yi, > > Did you mean rebas

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

> On May 26, 2015, 7:40 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-sql-core/src/main/java/org/apache/samza/sql/operators/scan/StreamScanSpec.java, > > line 28 > > > > > > Just a question: is this just a dummy

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

> On May 26, 2015, 7:40 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/ExecutionPlanner.java, > > line 189 > > > > > > The more I look at the use cas

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

> On May 26, 2015, 7:40 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/schema/Stream.java, > > line 80 > > > > > > Question: do we have a way to specify the p

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

> On May 26, 2015, 7:40 a.m., Yi Pan (Data Infrastructure) wrote: > > build.gradle, line 408 > > > > > > You might need to re-base this change. Hi Yi, Did you mean rebase my local samza-sql branch with master? > On

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33280/#review85153 --- Overall looks good to me. Thanks a lot! I just had one comment to us

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33280/ --- (Updated May 23, 2015, 4:27 p.m.) Review request for samza, Guozhang Wang and Y

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33280/ --- (Updated May 19, 2015, 6:58 p.m.) Review request for samza, Guozhang Wang and Y

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33280/ --- (Updated May 19, 2015, 6:06 p.m.) Review request for samza, Guozhang Wang and Y

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

> On May 12, 2015, 12:58 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/TypeAwareOperatorSpec.java, > > line 34 > > > > > > What about the operators w/

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

> On May 12, 2015, 12:58 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/ExecutionPlanner.java, > > line 114 > > > > > > In the new operator API, I me

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33280/#review83250 --- Looks good overall. Thanks for adding those end-to-end integration t

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33280/ --- (Updated April 19, 2015, 4:49 a.m.) Review request for samza and Yi Pan (Data I

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33280/ --- (Updated April 19, 2015, 4:43 a.m.) Review request for samza and Yi Pan (Data I

Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33280/ --- Review request for samza and Yi Pan (Data Infrastructure). Bugs: SAMZA-561