Re: Review Request 33142: [SAMZA-561] Review in progress

> On April 14, 2015, 10:14 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-sql/src/main/java/org/apache/samza/sql/metadata/Stream.java, line 37 > > > > > > What's the meaning of this parent? > > Milinda Pathirage w

Re: Review Request 33142: [SAMZA-561] Review in progress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33142/#review80897 --- Ship it! Looks very sound, for the stage we are at. Nice work. I h

Re: Review Request 33142: [SAMZA-561] Review in progress

> On April 14, 2015, 10:14 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-sql/src/main/java/org/apache/samza/sql/metadata/Stream.java, line 37 > > > > > > What's the meaning of this parent? > > Milinda Pathirage w

Re: Review Request 33142: [SAMZA-561] Review in progress

> On April 14, 2015, 10:14 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-sql/src/main/java/org/apache/samza/sql/expressions/RexToJavaCompiler.java, > > line 153 > > > > > > Is "Buzz" the intended real class name

Re: Review Request 33142: [SAMZA-561] Review in progress

> On April 14, 2015, 10:14 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-sql/src/main/java/org/apache/samza/sql/expressions/RexToJavaCompiler.java, > > line 102 > > > > > > Just a question, is it supposed to thr

Re: Review Request 33142: [SAMZA-561] Review in progress

> On April 14, 2015, 10:14 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-sql/src/main/java/org/apache/samza/sql/metadata/RelDataTypeToAvroSchemaConverter.java, > > line 28 > > > > > > One question here: it seems

Re: Review Request 33142: [SAMZA-561] Review in progress

> On April 14, 2015, 10:14 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-sql/src/main/java/org/apache/samza/sql/expressions/RexToJavaCompiler.java, > > line 102 > > > > > > Just a question, is it supposed to thr

Re: Review Request 33142: [SAMZA-561] Review in progress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33142/#review79941 --- I will continue the rest of the review after this patch is rebased a

Review Request 33142: [SAMZA-561] Review in progress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33142/ --- Review request for samza and Milinda Pathirage. Bugs: SAMZA-561 https://iss