Re: Review Request 32147: SAMZA-465

> On April 29, 2015, 7:30 p.m., Yan Fang wrote: > > samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamSystemConsumer.java, > > line 149 > > > > > > Will this bootstrappedStreamSet overflow

Re: Review Request 32147: SAMZA-465

> On April 29, 2015, 7:30 p.m., Yan Fang wrote: > > samza-core/src/main/java/org/apache/samza/storage/ChangelogPartitionManager.java, > > lines 60-68 > > > > > > actually, we do not need the consumer after boostrapping

Re: Review Request 32147: SAMZA-465

> On April 29, 2015, 7:30 p.m., Yan Fang wrote: > > samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamSystemConsumer.java, > > line 149 > > > > > > Will this bootstrappedStreamSet overflow

Re: Review Request 32147: SAMZA-465

> On April 29, 2015, 7:30 p.m., Yan Fang wrote: > > samza-core/src/main/java/org/apache/samza/storage/ChangelogPartitionManager.java, > > lines 60-68 > > > > > > actually, we do not need the consumer after boostrapping

Re: Review Request 32147: SAMZA-465

> On April 29, 2015, 8:38 p.m., Naveen Somasundaram wrote: > > samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamMessage.java, > > line 448 > > > > > > This is consistent with how it was pr

Re: Review Request 32147: SAMZA-465

> On April 29, 2015, 7:30 p.m., Yan Fang wrote: > > samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamSystemConsumer.java, > > line 149 > > > > > > Will this bootstrappedStreamSet overflow

Re: Review Request 32147: SAMZA-465

> On April 29, 2015, 7:30 p.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala, line 90 > > > > > > move it to the beginning of this class? This is an mistake from copy-paste :),

Re: Review Request 32147: SAMZA-465

> On April 29, 2015, 7:30 p.m., Yan Fang wrote: > > samza-core/src/main/java/org/apache/samza/checkpoint/CheckpointManager.java, > > line 98 > > > > > > why do we need to bootstrap everytime we call this method? We ne

Re: Review Request 32147: SAMZA-465

- Naveen --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32147/#review81995 --- On April 10, 2015, 3:13 a.m., Naveen Somasundaram wrote:

Re: Review Request 32147: SAMZA-465

> On April 29, 2015, 7:30 p.m., Yan Fang wrote: > > samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamMessage.java, > > line 436 > > > > > > typo, SetChangelogMapping? I'll fix this when I

Re: Review Request 32147: SAMZA-465

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32147/#review82006 --- samza-core/src/main/java/org/apache/samza/checkpoint/CheckpointMana

Re: Review Request 32147: SAMZA-465

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32147/#review81995 --- samza-core/src/main/java/org/apache/samza/checkpoint/CheckpointMana

Re: Review Request 32147: SAMZA-465

> On April 2, 2015, 11:22 p.m., Chris Riccomini wrote: > > samza-core/src/main/java/org/apache/samza/checkpoint/CheckpointManager.java, > > line 43 > > > > > > Can we make this private final, and call new in the cons

Re: Review Request 32147: SAMZA-465

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32147/ --- (Updated April 3, 2015, 12:52 a.m.) Review request for samza. Changes ---

Re: Review Request 32147: SAMZA-465

> On April 2, 2015, 11:35 p.m., Chris Riccomini wrote: > > samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamMessage.java, > > line 458 > > > > > > typo fixed > On April 2, 2015, 11:35

Re: Review Request 32147: SAMZA-465

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32147/#review78743 --- samza-core/src/main/java/org/apache/samza/coordinator/stream/Coordi

Re: Review Request 32147: SAMZA-465

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32147/#review78680 --- samza-core/src/main/java/org/apache/samza/checkpoint/CheckpointMana

Re: Review Request 32147: SAMZA-465

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32147/ --- (Updated April 1, 2015, 9:02 p.m.) Review request for samza. Changes ---

Re: Review Request 32147: SAMZA-465

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32147/ --- (Updated April 1, 2015, 7:44 p.m.) Review request for samza. Repository: samz

Re: Review Request 32147: SAMZA-465

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32147/ --- (Updated April 1, 2015, 5:37 p.m.) Review request for samza. Repository: samz

Re: Review Request 32147: SAMZA-465

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32147/#review77607 --- samza-core/src/main/java/org/apache/samza/coordinator/stream/Coordi

Re: Review Request 32147: SAMZA-465

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32147/#review77063 --- * Comb over all docs and update checkpoint manager docs. * Add some

Re: Review Request 32147: SAMZA-465

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32147/ --- (Updated March 17, 2015, 11:25 p.m.) Review request for samza. Repository: sa

Re: Review Request 32147: SAMZA-465

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32147/ --- (Updated March 17, 2015, 2:53 a.m.) Review request for samza. Repository: sam

Re: Review Request 32147: SAMZA-465

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32147/ --- (Updated March 17, 2015, 2:45 a.m.) Review request for samza. Repository: sam

Review Request 32147: SAMZA-465

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32147/ --- Review request for samza. Repository: samza Description --- SAMZA 465