Re: Review Request 32006: SAMZA-597

2015-03-13 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32006/#review76430 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On March 13, 20

Re: Review Request 32006: SAMZA-597

2015-03-13 Thread Chris Riccomini
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32006/ --- (Updated March 13, 2015, 8:39 p.m.) Review request for samza. Repository: sam

Re: Review Request 32006: SAMZA-597

2015-03-13 Thread Chris Riccomini
> On March 13, 2015, 5:31 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java, > > line 54 > > > > > > It seems that the default is set to false. Just

Re: Review Request 32006: SAMZA-597

2015-03-13 Thread Chris Riccomini
> On March 13, 2015, 6:24 p.m., Yan Fang wrote: > > samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java, > > line 109 > > > > > > what is the reason of getting rid of the system serde? I just did

Re: Review Request 32006: SAMZA-597

2015-03-13 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32006/#review76396 --- samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig

Re: Review Request 32006: SAMZA-597

2015-03-13 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32006/#review76381 --- samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig

Review Request 32006: SAMZA-597

2015-03-12 Thread Chris Riccomini
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32006/ --- Review request for samza. Repository: samza Description --- add docs f