Re: Review Request 30287: Stream SQL Object Model Draft

2015-01-30 Thread Yi Pan (Data Infrastructure)
> On Jan. 28, 2015, 12:30 a.m., Chris Riccomini wrote: > > samza-sql/src/main/java/org/apache/samza/sql/om/FromExpression.java, line 28 > > > > > > This class is a little confusing to me. 1) it doesn't extend > > expre

Re: Review Request 30287: Stream SQL Object Model Draft

2015-01-29 Thread Milinda Pathirage
> On Jan. 28, 2015, 12:30 a.m., Chris Riccomini wrote: > > samza-sql/src/main/java/org/apache/samza/sql/om/FieldReference.java, line 29 > > > > > > Should we consider referencing streams from different systems? > > "ka

Re: Review Request 30287: Stream SQL Object Model Draft

2015-01-27 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30287/#review69927 --- The examples look clean and neat. I really liked it. One high-level

Re: Review Request 30287: Stream SQL Object Model Draft

2015-01-27 Thread Chris Riccomini
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30287/#review69922 --- samza-sql/src/main/java/org/apache/samza/sql/om/FieldReference.java

Re: Review Request 30287: Stream SQL Object Model Draft

2015-01-26 Thread Milinda Pathirage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30287/ --- (Updated Jan. 26, 2015, 10:04 p.m.) Review request for samza, Chris Riccomini a

Review Request 30287: Stream SQL Object Model Draft

2015-01-26 Thread Milinda Pathirage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30287/ --- Review request for samza, Chris Riccomini and Yi Pan (Data Infrastructure). Rep