Re: Review Request 50318: SAMZA-979: Remove KafkaCheckpointMigration

2016-07-28 Thread Yi Pan (Data Infrastructure)
> On July 26, 2016, 10:39 p.m., Boris Shkolnik wrote: > > Are we sure that noone will try to upgraded from a version before migration > > to version 11 directly? We never test upgrading a version from 0.9 to 0.11 for all the changes. Even we keep this code around, the confidence of upgrading d

Re: Review Request 50318: SAMZA-979: Remove KafkaCheckpointMigration

2016-07-26 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50318/#review143632 --- Ship it! Are we sure that noone will try to upgraded from a ver

Re: Review Request 50318: SAMZA-979: Remove KafkaCheckpointMigration

2016-07-26 Thread Navina Ramesh
> On July 25, 2016, 11:19 p.m., Navina Ramesh wrote: > > samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala, > > line 226 > > > > > > This info looks pretty useful. Any particular reason you a

Re: Review Request 50318: SAMZA-979: Remove KafkaCheckpointMigration

2016-07-26 Thread Xinyu Liu
> On July 25, 2016, 11:19 p.m., Navina Ramesh wrote: > > samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala, > > line 226 > > > > > > This info looks pretty useful. Any particular reason you a

Re: Review Request 50318: SAMZA-979: Remove KafkaCheckpointMigration

2016-07-25 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50318/#review143446 --- Fix it, then Ship it! One question. Otherwise, looks good! +1

Re: Review Request 50318: SAMZA-979: Remove KafkaCheckpointMigration

2016-07-25 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50318/ --- (Updated July 25, 2016, 9:29 p.m.) Review request for samza, Navina Ramesh and